This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Web Vitals force page hide #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings back the hack we removed from PR #949. I've also added a test for it. When we remove the hack, the test fails, otherwise passes.
ka3de
force-pushed
the
fix/914-web-vital-force-page-hide
branch
from
31ee820 to
1ace782
Compare
This was referenced Jul 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reverting #949 in #964, which main purpose was to improve Web Vitals metrics consistent reporting, we need to provide an implementation that would achieve this consistency without the drawbacks introduced in #949 and explained in #964.
For that purpose this modification to force
pagehideevent has proven to be the better fix so far as commented in #960 (comment) and also similar to recommendations given in the Web Vitals library readme:Related #960.