-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for any database/sql
implementation
#17
Comments
There has been interest for other databases as evidenced by #11. |
As discussed over Slack, I don't think this project should aim to support any Since xk6 alone couldn't handle this build scenario, we can probably hack something up in a Dockerfile that does it. That said, I would argue that anyone who finds the current manual way of adding support for other RDBMSs difficult, would also find using Docker difficult, so I don't see how helpful automating that process would be. In that Slack discussion @mstoykov brought up the possibility of extensions having extensions ( |
As a note - there is no real need for any new tool or something in The only change is that Line 33 in b0a243a
xk6-sql-mysql to regsiter itself in the xk6-sql at which point xk6 build --with=path/to/xk6-sql-mysql shall suffice - you will just import it through k6/x/sql .
Now to be honest - I would argue this just means that we could as well not have |
Agreed, but having many more |
As for a having extensions depend upon extensions, I had brought that up when we were discussing the potential need for a Custom Integration Engineer position. E.g. the |
Hello guys, ERRO[0000] GoError: database oracle is not supported Any work around? |
Modularization takes into account and at the same time makes this issue obsolete. |
Go's
database/sql
abstraction layer allows for a common API provided by many SQL drivers. At the moment, we are limiting this to 4 specific dialects (mysql
,postgres
,sqlite
, andsqlserver
) due to the need to include the driver code for each within our extended k6 build.Ideally, we provide some sort of build option to allow the inclusion of the desired dialect(s) when creating the extended k6 version. Similar to the process followed by
xk6
, this would dynamically pull driver code into the source, updating import statements as necessary, then build the project with the new drivers. This would be better than having separatexk6-sql-*
, repositories only differing by driver code.The text was updated successfully, but these errors were encountered: