Feature: Oracle DB Support #24
Conversation
|
|
| @@ -56,7 +57,7 @@ func contains(array []string, element string) bool { | |||
| // Open establishes a connection to the specified database type using | |||
| // the provided connection string. | |||
| func (*SQL) Open(database string, connectionString string) (*dbsql.DB, error) { | |||
| supportedDatabases := []string{"mysql", "postgres", "sqlite3", "sqlserver"} | |||
| supportedDatabases := []string{"mysql", "postgres", "sqlite3", "sqlserver", "godror"} | |||
There was a problem hiding this comment.
| supportedDatabases := []string{"mysql", "postgres", "sqlite3", "sqlserver", "godror"} | |
| supportedDatabases := []string{"mysql", "postgres", "sqlite3", "sqlserver", "oracle"} |
|
Hi @stefnedelchev, thanks for the PR! Unfortunately we can't accept it, as we don't want to expand support for more SQL implementations internally. See #17 for details. Eventually, we'd like to split apart each currently supported dialect into standalone sub-extensions, so that users who need support for only e.g. PostgreSQL can build a binary that only has these drivers built-in, instead of the current 4. Adding more drivers to this list further complicates this. Besides, it's fairly trivial for users to build a k6 binary with an extension from their own or any other xk6-sql fork. Additionally, supporting Oracle DB specifically is a bit challenging, since it requires building with If you want to keep supporting your fork, we'd be happy to list it in our README, so that users who need Oracle support can use it. Let us know if you're OK with this. And please add the above documentation, if so. |
|
@imiric Fair enough, I understand. Sure, I can keep my fork and update its documentation. I'll let you know when I introduce these changes so the fork could be referenced. |
|
@imiric I updated the readme of my fork, changed the |
go mod tidyto consolidate Go packages and include godror packages to go.sum