fix: resolve headers when cross fetch is not available in environment #296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module supports using a custom fetch method, which is great when fetch is not supported in a given environment.
However,
resolveHeaders
function does not have into account thatcross-fetch
might be undefined. This was creating problems for me when using this module in a Cloudflare worker with the error:TypeError: Right-hand side of 'instanceof' is not an object
.This should have tests to avoid regressions, but at this point is quite complex to setup a test environment for this. I would suggest we can use something like https://github.com/hugomrdias/playwright-test and run tests in a service worker, but I left this for a follow up PR as I am not sure about how you would prefer to deal with this.