Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displayed TabBar font and badge color props (iOS >= 13) #613

Merged
merged 3 commits into from
Jul 10, 2022

Conversation

grahammendick
Copy link
Owner

Fixes #611

Used TabBarAppearance and TabBarItemAppearance introduced in iOS 13 because the old way doesn't work for font and badge color props

In ios 13 need to use appearance to style the tab bar. Still need the set title text attributes on tab bar item otherwise the font doesn't show properly on first load or when first switching tabs. So need both appearance in tab bar and title text attributes on tab bar item
Doesn't update if dynamically change the badge color (does after orientation change), but think this is v rare requirement.
Also applied fonts and badge color when landscape. Doesn't completely work because the unselected tab doesn't get the fonts applied, but think would have to apply global item appearance for that https://stackoverflow.com/questions/71194968/setting-a-uitabbarappearance-breaks-uitabbaritem-appearance-proxy-font-size-when/71195176#71195176
@grahammendick grahammendick merged commit 18c2b2a into master Jul 10, 2022
@grahammendick grahammendick deleted the tabbar-appearance branch July 10, 2022 16:47
grahammendick added a commit that referenced this pull request Jul 22, 2022
Forgot ios props have to be implemented in android view manager on Fabric. Also removed test id that made it in accidentally in copy paste of #613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TabBarItem - fontFamily not respected
1 participant