Supported landscape orientation (Android) #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followed existing pattern for backgroundColor, hidesTabBar etc. These props exist on both the NavigationStack (for global setting and for non-component api) and the Scene
Navigate from A --> B --> C with both B and C in landscape, then going back to B goes to portrait (unspecified). The getAnimation was returning null because the crumb was less than the current crumbs so it went back to default orientation. Changed to use the navigationEvent from state because that doesn't change when navigating - that's fixed for current scene. It's not guaranteed to be there, for example, fluent navigation, so used the navigationEvent from props if the one from state isn't there
Think this covers 99% of usecases because only ever want to change to landscape. Nobody wants upside down portrait, for example. Also think only want landscape that works no matter what direction user's phone is in - ltor or rtol - so went with user_landscape so automatically handled
Think the simulator behaves oddly so can't be 100% it's correct. There's interface orientation and device orientation. When rotating the simulator that changes both of these. When programmatically changing the orientation it also seems to change both but without rotating the simulator. So it's hard to know what position the 'real' device is in. But assuming that the device orientation is reliable indicator of its position. So when changing to landscape programmatically the device is actually rotated (even though simulator isn't). Basically can't replicate orientation landscape but device portrait in simulator
This reverts commit 32573d2.
Also typed the sharedElements prop on scene (it was only on the stack)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #690
Added landscape prop to
Sceneon Android. On iOS can only change orientation in full screen Modals (see Apple's UIKit video at 23:20).