Prevented SearchBar error when navigationImage missing from NavigationBar (Android) #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the navigation icon to null throws an error. The default is the search icon so makes sense to use it
The animation displays the search icon when transitioning from toolbar to results. Safer to turn it off if using a custom icon
Set navigation icon to home.png then open and closed the search, then removed the navigation icon and opened search again - the home icon was still shown when animating between toolbar and results. So simplified code by setting the animation just when attached to window. It doesn't fix the bug but no point updating each animation when it doesn't work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Material3
SearchBarthrows when the navigation icon is null. Used the default navigation icon if the user doesn't provide one. Disabled the navigation icon animation if not using the default otherwise Android shows the default icon when transitioning between the toolbar and results.