Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maxsplit= to support Bazel v1.0 #35

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

jmillikin-stripe
Copy link
Contributor

Bazel v1.0 changed some parameters to positional-only (bazelbuild/bazel#9998), which broke rules_r due to a use of maxsplit= in the repository setup. This PR fixes it.

@siddharthab
Copy link
Collaborator

Thank you! I will look at the test failure separately which appears to be unrelated to this.

@siddharthab siddharthab merged commit 3b6d326 into grailbio:master Nov 13, 2019
@jmillikin-stripe jmillikin-stripe deleted the support-bazel-v1.0 branch November 13, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants