Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge default config before application ctx is refreshed #174

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

dpcasady
Copy link
Contributor

The default audit log config must be merged into the main application config before the application context is refreshed otherwise the call to ReflectionUtils.setAuditConfig() will wipe out environment specific configs.

Take the following config snippet for example:

dataSource:
  someProperty: default-value

environments:
  development:
    dataSource:
      someProperty: custom-value

After startup in the dev env, grailsApplication.config.dataSource.someProperty would evaluate to default-value.

The default audit log config must be merged into the main application
config before the application context is refreshed otherwise the call to
ReflectionUtils.setAuditConfig() will wipe out environment specific
configs.
@dpcasady
Copy link
Contributor Author

FYI–looks as though the travis build has failed for reasons unrelated to the pull request.

@robertoschwald
Copy link
Contributor

I know. It is a Grails Artifactory problem.

@robertoschwald robertoschwald merged commit 7d3b25d into grails-plugins:master Aug 29, 2018
@dpcasady
Copy link
Contributor Author

Any chance you could do a point release that includes this fix? It's pretty crucial that application.yml is parsed into configs correctly. Thanks!

@dpcasady
Copy link
Contributor Author

Sorry to keep bugging you, but any chance you can do a release with this fix?

@robertoschwald
Copy link
Contributor

Version 3.0.2 released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants