Skip to content

Post review fixes #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025
Merged

Post review fixes #13

merged 2 commits into from
Jun 18, 2025

Conversation

sbglasius
Copy link
Contributor

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies several post-review fixes, including cleanup of publishing configuration, adjustments to packaging, dependency version bumps, and a Java version update.

  • Removed custom versionMapping from the Maven publication
  • Re-enabled inclusion of test emails and messages properties in the JAR
  • Bumped Grails, Nexus publish, and Asciidoctor Gradle plugin versions
  • Changed Java target from 17 to 11

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
gradle/publishing.gradle Removed versionMapping block from grailsPlugin publication
gradle/grails-plugin-config.gradle Deleted exclude('_testemails', 'messages*.properties')
gradle/buildsrc.libs.versions.toml Updated plugin versions: Grails, Nexus Publish, Asciidoctor
gradle.properties Downgraded javaVersion from 17 to 11
Comments suppressed due to low confidence (3)

gradle/grails-plugin-config.gradle:6

  • Removing this exclusion will package _testemails and messages*.properties into the JAR. If these files should remain internal, consider restoring the exclusion or adopting a resource filtering strategy.
    archiveClassifier = '' // Remove '-plain' suffix from jar file name

gradle/publishing.gradle:10

  • By removing the versionMapping block, consumers of the published POM may receive incorrect dependency constraints for API vs. runtime usage. If this change is intentional, please document why version mapping is no longer needed or verify that downstream consumers still resolve correct versions.
            from javaComponent.get()

gradle.properties:2

  • [nitpick] Downgrading the Java target to 11 may require updates to CI configurations, Docker images, and project documentation—please ensure all build environments and docs reflect this change.
javaVersion=11

Copy link
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one comment


grailsGradlePluginVersion=6.2.4
version=0.1
javaVersion=11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property is still unused.
If you want to use it, which is a good idea, you can do:
sourceCompatibility = JavaVersion.toVersion(javaVersion)
in the java extension configuration blocks (two places: java-config.gradle and functional-tests/build.gradle)

@sbglasius sbglasius merged commit a1a5339 into 6.0.x Jun 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants