Add feature to run Geb specs with Testcontainers #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature enables easy running of geb tests in a container so you don't have to manage driver versions on the host machine.
The common package name used by grails plugins is `grails.plugin.{plugin-name}`.
The common package name used by grails plugins is `grails.plugin.{plugin-name}`.
For `ContainerGebSpec` to work, the serverPort needs to be set. This is done by adding the `@Integration` annotation to the test class.
- Use Gradle testFixtures feature to make test dependencies available to downstream projects without leaking them to the wrong scopes - Refactor `ContainerGebSpec` in co-operation with sbglasius to add more features and make it work without Docker Desktop.
|
@matrei Looks great. I am apparently not committer on grails, so I cannot do approvals |
Well, you should be. That is an easy fix 😄 |
|
@sbglasius I have submitted a request and you should see invites to a github team soon. |
jamesfredley
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
I suspect the servlet-api changes will likely change based on gpc/grails-mail#56 (comment)
After this change this library needs to be referenced with `integrationTestImplementation testFixtures('org.grails.plugins:geb')`
but now we are not leaking any test dependencies to downstream projects non-test configurations.
jamesfredley
approved these changes
Oct 17, 2024
sbglasius
approved these changes
Oct 22, 2024
matrei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a
ContainerGebSpecclass that can be used in place ofGebSpecand that will run the test browser in a container instead of directly on the host machine.