-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Grails 6 (v5.0.0) #44
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compatible with Groovy 3.0.19 Updated gradle build to use version catalogs Added renovate and dependabot Documentation generation has been disabled. Maybe create a separate project for documentation like grails/grails-data-mapping -> grails/gorm-docs
@puneetbehl Please review |
4 tasks
Is there a reason to not publish documentation in here anymore? |
No, not really. I don't know why it was done that way in the grails-data-mapping, so I wanted to ask if that was the way to do it going forward. |
Resolves #35 |
matrei
added a commit
to grails/grails-core
that referenced
this pull request
Oct 3, 2024
This commit adds the Events plugin to all Grails applications by adding it to the `grails-dependencies`. Previously this has happened transitively through the inclusion of the Async plugin in `grails-dependencies`. However, as `grails-plugin-async` does not depend on the `grails-plugin-events`, it makes more sense to add `grails-plugin-events` in `grails-dependencies` explicitly. This prepares for the removal of `grails-plugins-events` to be declared as a dependency in `grails-plugin-async`. Related: grails/grails-async#44 grails/grails-async#69 grails/grails-async#70 #13324
matrei
added a commit
to grails/grails-core
that referenced
this pull request
Oct 3, 2024
* fix: Add `grails-plugin-events` to `grails-dependencies` This commit adds the Events plugin to all Grails applications by adding it to the `grails-dependencies`. Previously this has happened transitively through the inclusion of the Async plugin in `grails-dependencies`. However, as `grails-plugin-async` does not depend on the `grails-plugin-events`, it makes more sense to add `grails-plugin-events` in `grails-dependencies` explicitly. This prepares for the removal of `grails-plugins-events` to be declared as a dependency in `grails-plugin-async`. Related: grails/grails-async#44 grails/grails-async#69 grails/grails-async#70 #13324 * fix: Remove unnecessary exclusions of `javax:javaee-web-api` These exclusions should not be necessary anymore as `javax:javaee-web-api` is not included in `grails-plugin-async` or `grails-gsp`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatible with Groovy 3.0.19
Updated gradle build to use version catalogs
Added renovate and dependabot
Documentation generation has been disabled. Maybe create a separate project for documentation like grails/grails-data-mapping -> grails/gorm-docs