Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the pre-installed Chrome driver when running on GitHub #123

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

darxriggs
Copy link
Contributor

@darxriggs darxriggs commented Feb 9, 2022

This makes sure that the Chrome driver version matches the Chrome version.

@darxriggs
Copy link
Contributor Author

@puneetbehl Have the checks been disabled temporarily (no GitHub actions have been run for this pull request)?

@puneetbehl
Copy link
Contributor

@darxriggs Yes, there were some changes in the Github Workflow. Could you please rebase your changes now?

@darxriggs darxriggs force-pushed the fix-selenium-on-github branch 4 times, most recently from 04b6f46 to c192595 Compare February 11, 2022 19:19
@darxriggs darxriggs force-pushed the fix-selenium-on-github branch from c192595 to 4395dce Compare February 11, 2022 19:25
@darxriggs
Copy link
Contributor Author

@puneetbehl Now I managed it to properly integrate the tooling with the GitHub workflow.

@puneetbehl puneetbehl merged commit f77a3c0 into grails:5.0.x Feb 12, 2022
@darxriggs darxriggs deleted the fix-selenium-on-github branch February 12, 2022 15:09
puneetbehl added a commit to grails/grails-functional-tests that referenced this pull request Mar 21, 2022
puneetbehl added a commit to grails/grails-functional-tests that referenced this pull request Mar 21, 2022
puneetbehl added a commit to grails/grails-functional-tests that referenced this pull request Mar 21, 2022
puneetbehl added a commit to grails/grails-functional-tests that referenced this pull request May 1, 2022
* Use the pre-installed Chrome driver when running on GitHub (#106)

The GitHub virtual environment already provides a Chrome and a matching Chrome driver.

For installed software see:
https://github.com/actions/virtual-environments/blob/ubuntu20/20220207.1/images/linux/Ubuntu2004-Readme.md#environment-variables-1

For available environment variables see:
https://docs.github.com/en/actions/learn-github-actions/environment-variables

Thanks to @darxriggs for suggesting the same in grails/grails-cache#123 plugin.

* Update dependency org.grails:grails-gradle-plugin to v5.1.4

Co-authored-by: Puneet Behl <behlp@objectcomputing.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
puneetbehl added a commit to grails/grails-functional-tests that referenced this pull request May 1, 2022
…6.5 (#105)

* Use the pre-installed Chrome driver when running on GitHub (#106)

The GitHub virtual environment already provides a Chrome and a matching Chrome driver.

For installed software see:
https://github.com/actions/virtual-environments/blob/ubuntu20/20220207.1/images/linux/Ubuntu2004-Readme.md#environment-variables-1

For available environment variables see:
https://docs.github.com/en/actions/learn-github-actions/environment-variables

Thanks to @darxriggs for suggesting the same in grails/grails-cache#123 plugin.

* Update plugin com.gradle.common-custom-user-data-gradle-plugin to v1.6.5

Co-authored-by: Puneet Behl <behlp@objectcomputing.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
puneetbehl added a commit to grails/grails-functional-tests that referenced this pull request Jun 16, 2022
* Use the pre-installed Chrome driver when running on GitHub (#106)

The GitHub virtual environment already provides a Chrome and a matching Chrome driver.

For installed software see:
https://github.com/actions/virtual-environments/blob/ubuntu20/20220207.1/images/linux/Ubuntu2004-Readme.md#environment-variables-1

For available environment variables see:
https://docs.github.com/en/actions/learn-github-actions/environment-variables

Thanks to @darxriggs for suggesting the same in grails/grails-cache#123 plugin.

* Update assetPipelineVersion to v3.4.6

* Remove asset-pipeline plugin from uneccessary projects.

Co-authored-by: Puneet Behl <behlp@objectcomputing.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
puneetbehl added a commit to grails/grails-spring-security-core that referenced this pull request Nov 17, 2022
puneetbehl added a commit to grails/grails-spring-security-core that referenced this pull request Nov 17, 2022
puneetbehl added a commit to grails/grails-spring-security-core that referenced this pull request Nov 17, 2022
puneetbehl added a commit to grails/grails-spring-security-core that referenced this pull request Nov 17, 2022
* Use UrlPathHelper to resolve request URI

* Use the pre-installed Chrome driver when running on GitHub

The GitHub virtual environment already provides a Chrome and a matching Chrome driver.

For installed software see:
https://github.com/actions/virtual-environments/blob/ubuntu20/20220207.1/images/linux/Ubuntu2004-Readme.md#environment-variables-1

For available environment variables see:
https://docs.github.com/en/actions/learn-github-actions/environment-variables

Thanks to @darxriggs for suggesting the same in grails/grails-cache#123 plugin.

* Downgrade Selenium version

* Use Correct Selenium Versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants