-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the pre-installed Chrome driver when running on GitHub #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darxriggs
referenced
this pull request
Feb 9, 2022
This was referenced Feb 9, 2022
Merged
@puneetbehl Have the checks been disabled temporarily (no GitHub actions have been run for this pull request)? |
@darxriggs Yes, there were some changes in the Github Workflow. Could you please rebase your changes now? |
darxriggs
force-pushed
the
fix-selenium-on-github
branch
4 times, most recently
from
February 11, 2022 19:19
04b6f46
to
c192595
Compare
The GitHub virtual environment already provides a Chrome and a matching Chrome driver. For installed software see: https://github.com/actions/virtual-environments/blob/ubuntu20/20220207.1/images/linux/Ubuntu2004-Readme.md#environment-variables-1 For available environment variables see: https://docs.github.com/en/actions/learn-github-actions/environment-variables
darxriggs
force-pushed
the
fix-selenium-on-github
branch
from
February 11, 2022 19:25
c192595
to
4395dce
Compare
@puneetbehl Now I managed it to properly integrate the tooling with the GitHub workflow. |
puneetbehl
added a commit
to grails/grails-functional-tests
that referenced
this pull request
Mar 21, 2022
The GitHub virtual environment already provides a Chrome and a matching Chrome driver. For installed software see: https://github.com/actions/virtual-environments/blob/ubuntu20/20220207.1/images/linux/Ubuntu2004-Readme.md#environment-variables-1 For available environment variables see: https://docs.github.com/en/actions/learn-github-actions/environment-variables Thanks to @darxriggs for suggesting the same in grails/grails-cache#123 plugin.
puneetbehl
added a commit
to grails/grails-functional-tests
that referenced
this pull request
Mar 21, 2022
The GitHub virtual environment already provides a Chrome and a matching Chrome driver. For installed software see: https://github.com/actions/virtual-environments/blob/ubuntu20/20220207.1/images/linux/Ubuntu2004-Readme.md#environment-variables-1 For available environment variables see: https://docs.github.com/en/actions/learn-github-actions/environment-variables Thanks to @darxriggs for suggesting the same in grails/grails-cache#123 plugin.
puneetbehl
added a commit
to grails/grails-functional-tests
that referenced
this pull request
Mar 21, 2022
The GitHub virtual environment already provides a Chrome and a matching Chrome driver. For installed software see: https://github.com/actions/virtual-environments/blob/ubuntu20/20220207.1/images/linux/Ubuntu2004-Readme.md#environment-variables-1 For available environment variables see: https://docs.github.com/en/actions/learn-github-actions/environment-variables Thanks to @darxriggs for suggesting the same in grails/grails-cache#123 plugin.
puneetbehl
added a commit
to grails/grails-functional-tests
that referenced
this pull request
May 1, 2022
* Use the pre-installed Chrome driver when running on GitHub (#106) The GitHub virtual environment already provides a Chrome and a matching Chrome driver. For installed software see: https://github.com/actions/virtual-environments/blob/ubuntu20/20220207.1/images/linux/Ubuntu2004-Readme.md#environment-variables-1 For available environment variables see: https://docs.github.com/en/actions/learn-github-actions/environment-variables Thanks to @darxriggs for suggesting the same in grails/grails-cache#123 plugin. * Update dependency org.grails:grails-gradle-plugin to v5.1.4 Co-authored-by: Puneet Behl <behlp@objectcomputing.com> Co-authored-by: Renovate Bot <bot@renovateapp.com>
puneetbehl
added a commit
to grails/grails-functional-tests
that referenced
this pull request
May 1, 2022
…6.5 (#105) * Use the pre-installed Chrome driver when running on GitHub (#106) The GitHub virtual environment already provides a Chrome and a matching Chrome driver. For installed software see: https://github.com/actions/virtual-environments/blob/ubuntu20/20220207.1/images/linux/Ubuntu2004-Readme.md#environment-variables-1 For available environment variables see: https://docs.github.com/en/actions/learn-github-actions/environment-variables Thanks to @darxriggs for suggesting the same in grails/grails-cache#123 plugin. * Update plugin com.gradle.common-custom-user-data-gradle-plugin to v1.6.5 Co-authored-by: Puneet Behl <behlp@objectcomputing.com> Co-authored-by: Renovate Bot <bot@renovateapp.com>
puneetbehl
added a commit
to grails/grails-functional-tests
that referenced
this pull request
Jun 16, 2022
* Use the pre-installed Chrome driver when running on GitHub (#106) The GitHub virtual environment already provides a Chrome and a matching Chrome driver. For installed software see: https://github.com/actions/virtual-environments/blob/ubuntu20/20220207.1/images/linux/Ubuntu2004-Readme.md#environment-variables-1 For available environment variables see: https://docs.github.com/en/actions/learn-github-actions/environment-variables Thanks to @darxriggs for suggesting the same in grails/grails-cache#123 plugin. * Update assetPipelineVersion to v3.4.6 * Remove asset-pipeline plugin from uneccessary projects. Co-authored-by: Puneet Behl <behlp@objectcomputing.com> Co-authored-by: Renovate Bot <bot@renovateapp.com>
puneetbehl
added a commit
to grails/grails-spring-security-core
that referenced
this pull request
Nov 17, 2022
The GitHub virtual environment already provides a Chrome and a matching Chrome driver. For installed software see: https://github.com/actions/virtual-environments/blob/ubuntu20/20220207.1/images/linux/Ubuntu2004-Readme.md#environment-variables-1 For available environment variables see: https://docs.github.com/en/actions/learn-github-actions/environment-variables Thanks to @darxriggs for suggesting the same in grails/grails-cache#123 plugin.
puneetbehl
added a commit
to grails/grails-spring-security-core
that referenced
this pull request
Nov 17, 2022
The GitHub virtual environment already provides a Chrome and a matching Chrome driver. For installed software see: https://github.com/actions/virtual-environments/blob/ubuntu20/20220207.1/images/linux/Ubuntu2004-Readme.md#environment-variables-1 For available environment variables see: https://docs.github.com/en/actions/learn-github-actions/environment-variables Thanks to @darxriggs for suggesting the same in grails/grails-cache#123 plugin.
puneetbehl
added a commit
to grails/grails-spring-security-core
that referenced
this pull request
Nov 17, 2022
The GitHub virtual environment already provides a Chrome and a matching Chrome driver. For installed software see: https://github.com/actions/virtual-environments/blob/ubuntu20/20220207.1/images/linux/Ubuntu2004-Readme.md#environment-variables-1 For available environment variables see: https://docs.github.com/en/actions/learn-github-actions/environment-variables Thanks to @darxriggs for suggesting the same in grails/grails-cache#123 plugin.
puneetbehl
added a commit
to grails/grails-spring-security-core
that referenced
this pull request
Nov 17, 2022
* Use UrlPathHelper to resolve request URI * Use the pre-installed Chrome driver when running on GitHub The GitHub virtual environment already provides a Chrome and a matching Chrome driver. For installed software see: https://github.com/actions/virtual-environments/blob/ubuntu20/20220207.1/images/linux/Ubuntu2004-Readme.md#environment-variables-1 For available environment variables see: https://docs.github.com/en/actions/learn-github-actions/environment-variables Thanks to @darxriggs for suggesting the same in grails/grails-cache#123 plugin. * Downgrade Selenium version * Use Correct Selenium Versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that the Chrome driver version matches the Chrome version.