Remove @PendingFeature from tests which pass after grails/grails-test…

…ing-support#435
grails · Sep 29, 2024 · 05f3d1c · 05f3d1c
1 parent e408c92
commit 05f3d1c
Show file tree

Hide file tree

Showing 15 changed files with 0 additions and 35 deletions.
diff --git a/.../test/groovy/grails/test/mixin/DomainClassWithDefaultConstraintsUnitTestMixinTests.groovy b/.../test/groovy/grails/test/mixin/DomainClassWithDefaultConstraintsUnitTestMixinTests.groovy
@@ -13,7 +13,6 @@ class DomainClassWithDefaultConstraintsUnitTestMixinTests extends Specification
         }
     }}
 
-    @PendingFeature(reason = 'it is null')
     void testCreateDomainSingleLineWithConfigHavingNullableTrueForAllProperties() {
         expect:
         new DomainWithDefaultConstraints(name:"My test").save(flush:true) != null

diff --git a/...ber/src/test/groovy/grails/test/mixin/GroovyPageUnitTestMixinWithCustomViewDirSpec.groovy b/...ber/src/test/groovy/grails/test/mixin/GroovyPageUnitTestMixinWithCustomViewDirSpec.groovy
@@ -13,7 +13,6 @@ class GroovyPageUnitTestMixinWithCustomViewDirSpec extends Specification impleme
     }}
 
     @Issue('GRAILS=11543')
-    @PendingFeature(reason = 'result is null')
     void 'test rendering a template when grails.gsp.view.dir has been assigned a value'() {
         when:
         def result = render(template: '/demo/myTemplate')

diff --git a/grails-test-suite-uber/src/test/groovy/grails/test/mixin/StaticCallbacksSpec.groovy b/grails-test-suite-uber/src/test/groovy/grails/test/mixin/StaticCallbacksSpec.groovy
@@ -29,7 +29,6 @@ class StaticCallbacksSpec extends Specification implements GrailsUnitTest {
         grailsApplication.mainContext.getBean('myService') != null
     }
 
-    @PendingFeature(reason="myConfigValue is null")
     def "doWithConfig callback is executed"(){
         expect:
         config.myConfigValue == 'Hello'

diff --git a/grails-test-suite-uber/src/test/groovy/grails/test/mixin/TestInstanceCallbacksSpec.groovy b/grails-test-suite-uber/src/test/groovy/grails/test/mixin/TestInstanceCallbacksSpec.groovy
@@ -22,13 +22,11 @@ class TestInstanceCallbacksSpec extends Specification implements GrailsUnitTest
         grailsApplication != null
     }
 
-    @PendingFeature(reason = 'org.springframework.beans.factory.NoSuchBeanDefinitionException: No bean named \'myService\' available')
     def "doWithSpring callback is executed"() {
         expect:
         grailsApplication.mainContext.getBean('myService') != null
     }
 
-    @PendingFeature(reason = 'myConfigValue is null')
     def "doWithConfig callback is executed"(){
         expect:
         config.myConfigValue == 'Hello'

diff --git a/.../test/groovy/org/grails/web/metaclass/ChainMethodWithRequestDataValueProcessorSpec.groovy b/.../test/groovy/org/grails/web/metaclass/ChainMethodWithRequestDataValueProcessorSpec.groovy
@@ -14,7 +14,6 @@ class ChainMethodWithRequestDataValueProcessorSpec extends Specification impleme
         requestDataValueProcessor MockRequestDataValueProcessor
     }}
 
-    @PendingFeature(reason = '?requestDataValueProcessorParamName=paramValue is missing from URL')
     void 'test chain method with model and request data value processor'() {
         when:
         controller.save()

diff --git a/.../groovy/org/grails/web/servlet/mvc/RedirectMethodWithRequestDataValueProcessorSpec.groovy b/.../groovy/org/grails/web/servlet/mvc/RedirectMethodWithRequestDataValueProcessorSpec.groovy
@@ -12,7 +12,6 @@ class RedirectMethodWithRequestDataValueProcessorSpec extends Specification impl
         requestDataValueProcessor MockRequestDataValueProcessor
     }}
 
-    @PendingFeature(reason = '?requestDataValueProcessorParamName=paramValue is missing from URL')
     void 'test redirect in controller with all upper class class name'() {
         when:
         controller.index()
@@ -21,7 +20,6 @@ class RedirectMethodWithRequestDataValueProcessorSpec extends Specification impl
         "/redirect/list?requestDataValueProcessorParamName=paramValue" == response.redirectedUrl
     }
 
-    @PendingFeature(reason = '?requestDataValueProcessorParamName=paramValue is missing from URL')
     void 'test permanent redirect'() {
         when:
         controller.toActionPermanent()
@@ -31,7 +29,6 @@ class RedirectMethodWithRequestDataValueProcessorSpec extends Specification impl
         301 == response.status
     }
 
-    @PendingFeature(reason = '&requestDataValueProcessorParamName=paramValue is missing from URL')
     void 'test redirect to controller with duplicate params'() {
         when:
         controller.toControllerWithDuplicateParams()
@@ -40,7 +37,6 @@ class RedirectMethodWithRequestDataValueProcessorSpec extends Specification impl
         "/test/foo?one=two&one=three&requestDataValueProcessorParamName=paramValue" == response.redirectedUrl
     }
 
-    @PendingFeature(reason = '?requestDataValueProcessorParamName=paramValue is missing from URL')
     void 'test redirect with fragment'() {
         when:
         controller.toControllerAndActionWithFragment()
@@ -49,7 +45,6 @@ class RedirectMethodWithRequestDataValueProcessorSpec extends Specification impl
         "/test/foo?requestDataValueProcessorParamName=paramValue#frag" == response.redirectedUrl
     }
 
-    @PendingFeature(reason = '?requestDataValueProcessorParamName=paramValue is missing from URL')
     void 'test redirect to default action of another controller'() {
         when:
         controller.redirectToDefaultAction()
@@ -58,7 +53,6 @@ class RedirectMethodWithRequestDataValueProcessorSpec extends Specification impl
         "/redirect/toAction?requestDataValueProcessorParamName=paramValue" == response.redirectedUrl
     }
 
-    @PendingFeature(reason = '?requestDataValueProcessorParamName=paramValue is missing from URL')
     void 'test redirect to action'() {
         when:
         controller.toAction()
@@ -67,7 +61,6 @@ class RedirectMethodWithRequestDataValueProcessorSpec extends Specification impl
         "/redirect/foo?requestDataValueProcessorParamName=paramValue" == response.redirectedUrl
     }
 
-    @PendingFeature(reason = '?requestDataValueProcessorParamName=paramValue is missing from URL')
     void 'test redirect to controller'() {
         when:
         controller.toController()
@@ -76,7 +69,6 @@ class RedirectMethodWithRequestDataValueProcessorSpec extends Specification impl
         "/test?requestDataValueProcessorParamName=paramValue" == response.redirectedUrl
     }
 
-    @PendingFeature(reason = '&requestDataValueProcessorParamName=paramValue is missing from URL')
     void 'test redirect to controller with params'() {
         when:
         controller.toControllerWithParams()
@@ -85,7 +77,6 @@ class RedirectMethodWithRequestDataValueProcessorSpec extends Specification impl
         "/test/foo?one=two&two=three&requestDataValueProcessorParamName=paramValue" == response.redirectedUrl
     }
 
-    @PendingFeature(reason = '&requestDataValueProcessorParamName=paramValue is missing from URL')
     void 'test redirect to controller with duplicate array params'() {
         when:
         controller.toControllerWithDuplicateArrayParams()

diff --git a/grails-test-suite-web/src/test/groovy/grails/rest/web/RespondMethodSpec.groovy b/grails-test-suite-web/src/test/groovy/grails/rest/web/RespondMethodSpec.groovy
@@ -165,7 +165,6 @@ class RespondMethodSpec extends Specification implements ControllerUnitTest<Book
         modelAndView.viewName == 'showWithModel'
     }
 
-    @PendingFeature(reason = 'modelAndView is null')
     void "Test that the respond method produces errors HTML for a domain instance that has errors and a content type of HTML"() {
         given:"A book instance"
         def book = new Book(title: "")
@@ -183,7 +182,6 @@ class RespondMethodSpec extends Specification implements ControllerUnitTest<Book
         modelAndView.viewName == 'showWithModel'
     }
 
-    @PendingFeature(reason = 'modelAndView is null')
     void "Test that proxyHandler is used for unwrapping wrapped model"() {
         given:"A book instance"
         def book = new Book(title: "")

diff --git a/...ls-test-suite-web/src/test/groovy/org/grails/web/commandobjects/CommandObjectsSpec.groovy b/...ls-test-suite-web/src/test/groovy/org/grails/web/commandobjects/CommandObjectsSpec.groovy
@@ -160,7 +160,6 @@ class CommandObjectsSpec extends Specification implements ControllerUnitTest<Tes
         /[A-Z]+/ == matchesProperty
     }
 
-    @PendingFeature(reason='theAnswer is null')
     void "Test command object gets autowired"() {
         when:
         def model = controller.methodAction()
@@ -170,7 +169,6 @@ class CommandObjectsSpec extends Specification implements ControllerUnitTest<Tes
 
     }
 
-    @PendingFeature(reason='person has errors')
     void 'Test bindable command object constraint'() {
         when:
         controller.params.name = 'JFK'
@@ -185,7 +183,6 @@ class CommandObjectsSpec extends Specification implements ControllerUnitTest<Tes
         model.person.city == null
     }
 
-    @PendingFeature(reason='person has errors')
     void "Test validation"() {
         when:
         controller.params.name = 'JFK'

diff --git a/...s-test-suite-web/src/test/groovy/org/grails/web/converters/MarshallerRegistrarSpec.groovy b/...s-test-suite-web/src/test/groovy/org/grails/web/converters/MarshallerRegistrarSpec.groovy
@@ -16,7 +16,6 @@ class MarshallerRegistrarSpec extends Specification implements ControllerUnitTes
         marshallerRegistrar(MarshallerRegistrar)
     }}
 
-    @PendingFeature(reason = 'contentAsString = {"content":"Content","dateCreated":"2024-09-28T19:41:59Z"}')
     def "should use custom marshaller"() {
         when:
         controller.show()

diff --git a/...-suite-web/src/test/groovy/org/grails/web/mapping/DynamicActionNameEvaluatingTests.groovy b/...-suite-web/src/test/groovy/org/grails/web/mapping/DynamicActionNameEvaluatingTests.groovy
@@ -32,7 +32,6 @@ class DynamicActionNameEvaluatingTests extends Specification implements UrlMappi
         "read" == info.actionName
     }
 
-    @PendingFeature(reason = 'params.ctrl is null')
     void testNamedParameterAction2() {
         when:
         webRequest.params.put("controller", "book")

diff --git a/...-test-suite-web/src/test/groovy/org/grails/web/mapping/ResponseCodeUrlMappingTests.groovy b/...-test-suite-web/src/test/groovy/org/grails/web/mapping/ResponseCodeUrlMappingTests.groovy
@@ -60,7 +60,6 @@ class ResponseCodeUrlMappingTests extends Specification implements UrlMappingsUn
         !info
     }
 
-    @PendingFeature(reason = "delegate is instance of org.grails.web.mapping.RegexUrlMapping")
     void testNoReverseMappingOccures() {
         when:
         def creator = urlMappingsHolder.getReverseMapping("errors", "error404", null)

diff --git a/grails-test-suite-web/src/test/groovy/org/grails/web/mapping/UrlMappingParameterTests.groovy b/grails-test-suite-web/src/test/groovy/org/grails/web/mapping/UrlMappingParameterTests.groovy
@@ -27,7 +27,6 @@ class UrlMappingParameterTests extends Specification implements UrlMappingsUnitT
 
     }
 
-    @PendingFeature(reason='lang is null')
     void testUseDispatchAction() {
         when:
         webRequest.params.controller = 'foo'

diff --git a/grails-test-suite-web/src/test/groovy/org/grails/web/mapping/UrlMappingTests.groovy b/grails-test-suite-web/src/test/groovy/org/grails/web/mapping/UrlMappingTests.groovy
@@ -6,7 +6,6 @@ import spock.lang.Specification
 
 class UrlMappingTests extends Specification implements UrlMappingsUnitTest<UrlMappings> {
 
-    @PendingFeature(reason="grails.web.mapping.exceptions.UrlMappingException: Unable to create URL for mapping [/(*)/(*)?/(*)?(.(*))?] and parameters [{id=tsandcs}]. Parameter [controller] is required, but was not specified!")
     void testReverseTopLevelMapping() {
 
         when:

diff --git a/...ls-test-suite-web/src/test/groovy/org/grails/web/mime/ContentFormatControllerTests.groovy b/...ls-test-suite-web/src/test/groovy/org/grails/web/mime/ContentFormatControllerTests.groovy
@@ -48,7 +48,6 @@ class ContentFormatControllerTests extends Specification implements ControllerUn
         """{"name":"iPod"}""".toString() == response.contentAsString
     }
 
-    @PendingFeature(reason = 'html != all')
     void testAllFormat() {
         when:
         request.addHeader "Accept", "*/*"
@@ -58,7 +57,6 @@ class ContentFormatControllerTests extends Specification implements ControllerUn
         "all" == response.contentAsString
     }
 
-    @PendingFeature(reason = 'html != all')
     void testWithFormatAndAll() {
         when:
         request.addHeader "Accept", "*/*"
@@ -74,7 +72,6 @@ class ContentFormatControllerTests extends Specification implements ControllerUn
         "html" == response.format
     }
 
-    @PendingFeature(reason = 'html != all')
     void testWithFormatAndAll2() {
         when:
         request.addHeader "Accept", "*/*"
@@ -90,7 +87,6 @@ class ContentFormatControllerTests extends Specification implements ControllerUn
         "js" == response.format
     }
 
-    @PendingFeature(reason = 'html != all')
     void testDefaultFormat() {
         when:
         controller.testFormat()
@@ -99,7 +95,6 @@ class ContentFormatControllerTests extends Specification implements ControllerUn
         "all" == response.contentAsString
     }
 
-    @PendingFeature(reason = 'js != all')
     void testWithContentTypeAndAcceptHeader() {
         when:
         // should favour content type header
@@ -140,7 +135,6 @@ class ContentFormatControllerTests extends Specification implements ControllerUn
         "html" == request.format
     }
 
-    @PendingFeature(reason = 'js != all')
     void testPrototypeFormat() {
         when:
         request.addHeader "Accept", "text/javascript, text/html, application/xml, text/xml, */*"
@@ -179,7 +173,6 @@ class ContentFormatControllerTests extends Specification implements ControllerUn
         "<html></html>" == response.contentAsString
     }
 
-    @PendingFeature(reason = '<html></html> !=  alert(\'hello\')')
     void testPrototypeWithFormat() {
         when:
         request.addHeader "Accept", "text/javascript, text/html, application/xml, text/xml, */*"
@@ -189,7 +182,6 @@ class ContentFormatControllerTests extends Specification implements ControllerUn
         "alert('hello')" == response.contentAsString
     }
 
-    @PendingFeature(reason = '<html></html> !=  alert(\'hello\')')
     void testWithFormatParameterOverride() {
         when:
         request.setParameter "format", "js"

diff --git a/grails-test-suite-web/src/test/groovy/org/grails/web/mime/WithFormatContentTypeSpec.groovy b/grails-test-suite-web/src/test/groovy/org/grails/web/mime/WithFormatContentTypeSpec.groovy
@@ -19,7 +19,6 @@ class WithFormatContentTypeSpec extends Specification implements ControllerUnitT
     }}
 
     @Issue('GRAILS-11093')
-    @PendingFeature(reason = '/wildcardView != /formView')
     void 'Test specifying form contentType'() {
         when: 'content type is specified'
         request.contentType = FORM_CONTENT_TYPE
@@ -31,7 +30,6 @@ class WithFormatContentTypeSpec extends Specification implements ControllerUnitT
     }
 
     @Issue('GRAILS-11093')
-    @PendingFeature(reason = '/wildcardView != /formView')
     void 'Test specifying multipartForm contentType'() {
         when: 'content type is specified'
         request.contentType = MULTIPART_FORM_CONTENT_TYPE