-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.0.x dependency cleanup - new grails-bom #13787
7.0.x dependency cleanup - new grails-bom #13787
Conversation
The build is failing after the last cleanup commit 80534e7. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Scott!
Can we add the versions as properties in the pom like in https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/3.3.4/spring-boot-dependencies-3.3.4.pom
Like it is for the plugins and profiles.
Then it is easy to override the version ext.set('spring.version', '6.1.13')
There is also some overlap between spring-boot-dependencies
and grails-bom
. Do we want to clean that up?
grails-bom/build.gradle
Outdated
org.grails:grails-gdoc-engine::$gdocEngineVersion | ||
org.grails:grails-gradle-plugin::$grailsGradlePluginVersion | ||
org.grails:grails-testing-support,grails-gorm-testing-support,grails-web-testing-support::$testingSupportVersion | ||
org.grails:grails:gsp,web-gsp:$gspVersion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing some gsp modules here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what would you like added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In grails-mail
I wanted to use org.grails:grails-web-taglib
but it is missing from the bom.
I guess all modules from grails-gsp
should be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
web can clean it up. we just need to identify the overlap and make sure the versions don't need to be overridden.
if they are the same version, we should remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding the versioning is going to be a bit of work. I'd prefer to tackle that later. I made some attempts at it, but haven't had success yet. I haven't come up with or found a simple way of doing it yet. The previous version that worked was just building a maven bom which couldn't be used by the other projects. This is actually creating a bom type project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matrei I just didn't manually. Take a look, you have versions now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Right now spock-core
and spock-spring
get included twice the pom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added grails-web-taglib
I guess it doesn't like to resolve bom versions for documentation dependencies documentation("org.fusesource.jansi:jansi:$jansiVersion")
documentation("jline:jline:$jlineVersion")
documentation ("com.github.javaparser:javaparser-core:$javaParserCoreVersion") I added reverted the versions back. |
Wouldn't |
@matrei if I new I was going to make so many changes, I would have separated the task names a long time ago when you first asked. lol. 🤣 |
These are the version property names for the jakarta dependencies in <jakarta-annotation.version>2.1.1</jakarta-annotation.version>
<jakarta-inject.version>2.0.1</jakarta-inject.version>
<jakarta-persistence.version>3.1.0</jakarta-persistence.version>
<jakarta-servlet.version>6.0.0</jakarta-servlet.version>
<jakarta-xml-bind.version>4.0.2</jakarta-xml-bind.version> As much as I would like to support patch updates. The right thing is prob to resolve to Spring. removed... |
…ady requires a configuration exclusion. The locations that requires it should be updated to the current hamcrest version already referenced in the spring bom.
grails-core/gradle/docs.gradle Line 23 in 0342bd1
|
@matrei removed. |
I think this will be a lot easier to maintain. All version numbers have been pulled out and the entire grails-core repo now uses its own bom for dependency version resolution.
I provided a more concise, clean approach to listing dependency versions. The previous way was a bit more tedious and time consuming having to add a map entry for every dependency.
Check out those deletion stats 😉
Still work needs to be done to analyze dependency configurations, but this can be done in a later ticket.
Spring Bom
Groovy Bom
https://repo.grails.org/ui/native/core/org/grails/grails-bom/7.0.0-SNAPSHOT/