Filter order values should not be fixed and should be relative to requirements of Spring Boot. #13809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uirements of Spring Boot.
codeconsole
requested review from
davydotcom,
sbglasius,
jdaugherty,
matrei and
jamesfredley
jamesfredley
approved these changes
Oct 24, 2024
matrei
approved these changes
Oct 24, 2024
grails-plugin-controllers/src/main/groovy/org/grails/config/http/GrailsFilters.java
Show resolved
Hide resolved
grails-plugin-controllers/src/main/groovy/org/grails/config/http/GrailsFilters.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13797
This will evolve, but it is good to get the process started.
It was place in grails-controllers because that is where the used filters are instantiated. The other possible location is grails-bootstrap. These are the only 2 locations that depend on spring boot autoconfigure. This needs to be based on spring boot autoconfigure in case at some point Spring decides to change the default value (A situation like this broke the Grails Spring Security Core plugin which was previously dependent on fixed numerical values that became outdated )
Asset pipeline PR should be merged after this is accepted.
Sitemesh plugin will be updated after this is accepted.