6.1.12.RELEASE / 7.0.1.RELEASE BUG - Unable to save changes from custom GORM EventListener

[codeconsole]

The following worked in Grails 3.3.9 and below:

In Grails 3.3.10 and 4.0.0, the listener code is executed, but the changes performed on the entityObject are no longer persisted.

Assuming a class Example with a field prop, we want to create a Listener that will automatically set prop on an Insert event.

class Example {

	Date created = new Date()
	String prop

    static constraints = {
    	created()
    	prop nullable: true
    }
}

@CompileStatic
class ExampleListener extends AbstractPersistenceEventListener {

    ExampleListener(final Datastore datastore) {
        super(datastore)
    }

    @Override
    @CompileStatic(TypeCheckingMode.SKIP) 
    protected void onPersistenceEvent(AbstractPersistenceEvent event) {
        def o = event.entityObject
        o.prop = 'autoset'
        println "Autoset"
    }

    @Override
    boolean supportsEventType(Class<? extends ApplicationEvent> eventType) {
        eventType == PreUpdateEvent || eventType == PreInsertEvent
    }
}

The following code can be demonstrated here:
https://github.com/codeconsole/listenerbug

git clone https://github.com/codeconsole/listenerbug
# set version to Grails 4.0.0
grails run-app

To demonstrate the bug on Grails 3.x

# set version to Grails 3.3.10 and checkout the 3.3.10 tag
git checkout 3.3.10
grails run-app

Rolling back gormVersion=6.1.11.RELEASE in gradle.properties on Grails 3.3.10 fixes the issue.
this can be demonstrated by switching to tag working using grails 3.3.10

# set version to Grails 3.3.10 and checkout the 3.3.10 tag
git checkout working
grails run-app

https://github.com/grails/grails-data-mapping/compare/v6.1.11..v6.1.12

[puneetbehl]

I believe this is caused by issue #1064 because we removed activateDirtyChecking method call from ClosureEventTriggeringInterceptor::onSaveOrUpdate.