dependency cleanup with grails-bom #384
Conversation
| hibernate5Version=5.6.15.Final | ||
| servletApiVersion=6.0.0 | ||
| groovyVersion=4.0.23 | ||
| # Tests are built for this version | ||
| h2Version=1.4.200 |
There was a problem hiding this comment.
I think the h2 version is held back on purpose here, considering the comment above.
There was a problem hiding this comment.
It is, but the tests are based on this version so it is overridden.
There was a problem hiding this comment.
how are tests based on a version of a database?
There was a problem hiding this comment.
There are compatibility issues with h2:2.x. #385
There was a problem hiding this comment.
well, hopefully we will get to updating them at some point.. My h2 issues always have been pretty straightforward upgraades with the exception of cases where I had to do a persisted database update.
There was a problem hiding this comment.
I have updated the tests in for h2:2.x but I'll wait for this PR to merge before creating a PR because there are some changes here I need.
| hibernate5Version=5.6.15.Final | ||
| servletApiVersion=6.0.0 | ||
| groovyVersion=4.0.23 | ||
| # Tests are built for this version | ||
| h2Version=1.4.200 |
There was a problem hiding this comment.
I think the h2 version is held back on purpose here, considering the comment above.
No description provided.