Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#139: loadQuartzProperties getProperty replaced with get #140

Merged
merged 1 commit into from
Jan 9, 2025
Merged

#139: loadQuartzProperties getProperty replaced with get #140

merged 1 commit into from
Jan 9, 2025

Conversation

miguelabautista
Copy link
Contributor

in loadQuartzProperties getProperty won't retrieve the configuration properties. I replaced it with get

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@miguelabautista miguelabautista mentioned this pull request Jan 9, 2025
Closed
@amondel2
Copy link
Contributor

amondel2 commented Jan 9, 2025 •
edited
Loading

This looks good, here is a good explanation of get versus getProperty https://stackoverflow.com/questions/11104395/difference-between-get-vs-getproperty

@jamesfredley
Copy link
Contributor

@amondel2 Thank you. Feel free to merge this when ready.

@amondel2 amondel2 merged commit 2b38341 into grails:4.0.x Jan 9, 2025
5 checks passed
@amondel2
Copy link
Contributor

amondel2 commented Jan 9, 2025

Thank you @miguelabautista

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amondel2 amondel2 amondel2 approved these changes

@arjangch arjangch Awaiting requested review from arjangch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miguelabautista @CLAassistant @amondel2 @jamesfredley