Grails 7 compatibility #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example test project does not currently work and blocks progress. This commit disables it from the build temporarily until conditions have changed.
|
Related: grails/grails-core#13555 |
sdelamo
reviewed
Aug 9, 2024
build.gradle
Outdated
| @@ -42,7 +52,7 @@ subprojects { project -> | |||
| } | |||
|
|
|||
| repositories { | |||
| mavenLocal() | |||
| //mavenLocal() | |||
There was a problem hiding this comment.
Suggested change
| //mavenLocal() |
| @@ -31,6 +31,6 @@ include 'grails-testing-support', | |||
| 'grails-web-testing-support', | |||
| 'grails-gorm-testing-support' | |||
|
|
|||
| include 'examples-demo33' | |||
| project(":examples-demo33").projectDir = new File(settingsDir, "examples/demo33") | |||
| //include 'examples-demo33' | |||
There was a problem hiding this comment.
@sdelamo The example test project does not currently work and blocks
progress. This commit disables it from the build temporarily
until conditions have changed.
sdelamo
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the project to Java 17, Groovy 4 and Jakarta.
Hopefully the SNAPSHOT can be used for getting some more tests in
grails-gspupdate to pass.