chore(cli)!: Remove graceful flag & behavior #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusroberts
approved these changes
May 28, 2022
ospencer
approved these changes
May 28, 2022
I actually don't know this for sure. I believe it is a flag from a bygone era that we don't need since @ospencer refactored the process spawning. Now, it not only collects stdout and stderr, but it also checks status codes. I'll double check with him to ensure this is the correct answer. |
|
Yup, that's correct! In fact, |
phated
force-pushed
the
phated/remove-wrap-action
branch
from
aacc67b
to
04155ea
Compare
Closed
Merged
This was referenced Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
--graceful/-gflag and removes the "graceful" exit behavior. I don't actually think this is necessary/useful and it just makes boilerplate more cluttered.