Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): Reduce boilerplate #1276

Merged
merged 1 commit into from
May 29, 2022
Merged

chore(cli): Reduce boilerplate #1276

merged 1 commit into from
May 29, 2022

Conversation

phated
Copy link
Member

@phated phated commented May 28, 2022

This is committed on top of #1275 because I noticed areas for cleanup after I removed that code. This just reduces a whole bunch of boilerplate that we don't need to deal with.

@phated phated requested a review from a team May 28, 2022 22:46
Copy link
Member

@marcusroberts marcusroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will need to update the LSP branch as we call the LSP code differently now

@phated phated force-pushed the phated/remove-wrap-action branch from aacc67b to 04155ea Compare May 29, 2022 18:32
Base automatically changed from phated/remove-wrap-action to main May 29, 2022 20:50
@phated phated force-pushed the phated/reduce-cli-boilerplate branch from 4386bd3 to 24610fa Compare May 29, 2022 21:03
@phated phated merged commit 002f570 into main May 29, 2022
@phated phated deleted the phated/reduce-cli-boilerplate branch May 29, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants