fix(compiler): Ensure constant number locations are propagated correctly when parsing #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
requested review from
peblair,
phated and
marcusroberts
as code owners
ospencer
force-pushed
the
oscar/number-locs
branch
from
d815fdf
to
6fc5cef
Compare
phated
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2042
I split the parsing of numbers into two distinct sets of rules: one for positive and one for negative numbers. This avoids a limitation with Menhir where
$sloclocations aren't carried beyond a single rule. I don't think I'd go so far as to say this is a bug with Menhir, though. I kind of wish this could be solved with an%inlinedeclaration, but they make an effort to have marking something inline not affect how the locations work. I may open an issue to ask/suggest a solution for this.