feat(compiler): Name globals in wasm output #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
force-pushed
the
oscar/func-table-refactor
branch
from
0c03f16
to
8902675
Compare
ospencer
force-pushed
the
oscar/refactor-globals
branch
from
a4b6d47
to
eb80b16
Compare
ospencer
force-pushed
the
oscar/func-table-refactor
branch
3 times, most recently
from
ff243e2
to
0133a2d
Compare
ospencer
force-pushed
the
oscar/refactor-globals
branch
from
eb80b16
to
e058860
Compare
ospencer
force-pushed
the
oscar/func-table-refactor
branch
from
0133a2d
to
9b0a798
Compare
ospencer
force-pushed
the
oscar/refactor-globals
branch
from
e058860
to
9d79ac7
Compare
ospencer
force-pushed
the
oscar/refactor-globals
branch
from
9d79ac7
to
8c00ba2
Compare
ospencer
force-pushed
the
oscar/refactor-globals
branch
from
8c00ba2
to
1947283
Compare
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more code cleanup than anything else, largely from old logic we needed back before we used Binaryen. Additionally, it'll make it easier for us to debug what's going in in the wasm output since we'll actually see the names of globals getting assigned rather than just
global_0etc.