chore!: Switch from yarn to npm #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(ci): Utilize npm dependency cache
|
I had the same on Windows. The Grain node CLI was installed here C:\Users\marcus\AppData\Local\Yarn\bin which Yarn bin doesn't report as a location. |
marcusroberts
approved these changes
May 15, 2022
ospencer
approved these changes
May 15, 2022
peblair
approved these changes
May 15, 2022
Merged
This was referenced Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on #1092
While working on Windows CI for Grain, I found out that the yarn global path is not available to our test harness for some reason (no idea why). By switching to npm, the grain binary will correctly be available to powershell.exe that is executed from our test runner (upcoming PR).
I was planning to make this change as soon as we dropped node 14 support, as npm 8 has workspace support and then users don't need to worry about having yarn installed.
The one downside to this change is that all of our
yarncommands are nownpm run. (don't 🔫 me)