fix(graindoc): Use value_descriptions and type_declarations defined by the module signature #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y the module signature
ospencer
force-pushed
the
oscar/fix-graindoc-type-reporting
branch
2 times, most recently
from
c96a69f
to
829c344
Compare
ospencer
force-pushed
the
oscar/fix-graindoc-type-reporting
branch
from
829c344
to
a5b31ee
Compare
phated
approved these changes
May 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously did a lookup on the types in the module's signature, but that type is the original type rather than what the module is trying to expose. This change uses what's defined in the signature.