fix(compiler): Read custom sections in full #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusroberts
approved these changes
May 22, 2022
phated
approved these changes
May 22, 2022
| } else { | ||
| process(tl); | ||
| }; | ||
| really_input(inchan, bytes, 0, realsize); |
There was a problem hiding this comment.
Is it okay that this will raise if we can't read it all?
There was a problem hiding this comment.
Indeed! If all the bytes aren't there (when the module reported that they were) means the module is corrupted.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we relied on OCaml's
inputto read the custom section from a module. If all the bytes were not read, we skipped the section entirely. This swaps toreally_inputto ensure we read the entire section.