Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): Convert Sys libraries to @unsafe #1272

Merged
merged 1 commit into from
May 28, 2022
Merged

Conversation

ospencer
Copy link
Member

Closes #1146 as this removes the sys functions' self-references, which allows them to be dropped from the module if unused.

@ospencer ospencer requested a review from a team May 28, 2022 02:29
@ospencer ospencer self-assigned this May 28, 2022
Copy link
Member

@marcusroberts marcusroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

)
let orderedRights = wasmSafeCons(
let orderedFdflags = [Append, Dsync, Nonblock, Rsync, Sync]
let orderedRights = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank god!

@ospencer ospencer merged commit fcdfc2a into main May 28, 2022
@ospencer ospencer deleted the oscar/unsafe-sys branch May 28, 2022 22:00
@github-actions github-actions bot mentioned this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import only necessary WASI APIs
3 participants