Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(graindoc): Enable printing of arrow types #1367

Merged
merged 1 commit into from
Jul 22, 2022
Merged

fix(graindoc): Enable printing of arrow types #1367

merged 1 commit into from
Jul 22, 2022

Conversation

ospencer
Copy link
Member

Fixes #1366

Also fixes the LSP problem (and this shows the output of the printer):
image

@phated we don't have any graindoc tests right?

@ospencer ospencer requested a review from a team July 22, 2022 01:23
@ospencer ospencer self-assigned this Jul 22, 2022
phated
phated approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ospencer ospencer merged commit e2b28ab into main Jul 22, 2022
@ospencer ospencer deleted the oscar/otyp-arrow branch July 22, 2022 19:30
@github-actions github-actions bot mentioned this pull request Jul 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@marcusroberts marcusroberts marcusroberts approved these changes

Assignees

@ospencer ospencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grain doc fails upon seeing type alias
3 participants
@ospencer @phated @marcusroberts