feat(stdlib): Add Number.tan, Number.factorial, Number.clamp, Number.lerp
#1373
Conversation
spotandjake
changed the title
Number.tan, Number.factorial, Number.clamp, Number.lerp, Number.map
- Undo Changes To GitIgnore - Update Doc Versions - Update Docs On Lerp
Rewrite Number.Factorial To Use Recurrsion
|
I made the changes we talked about in discord i will move |
spotandjake
changed the title
Number.tan, Number.factorial, Number.clamp, Number.lerp, Number.mapNumber.tan, Number.factorial, Number.clamp, Number.lerp
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
| /** | ||
| * Computes the factorial of a number. | ||
| * | ||
| * @param input: The number to compute the factorial of, Must be a Non negative integer |
There was a problem hiding this comment.
| * @param input: The number to compute the factorial of, Must be a Non negative integer | |
| * @param input: The non-negative integer used to compute the factorial |
| */ | ||
| export let factorial = input => { | ||
| // Error If It is Negative, or Not an Integer | ||
| if (sign(input) is -1 || isInteger(input)) { |
There was a problem hiding this comment.
| if (sign(input) is -1 || isInteger(input)) { | |
| if (input < 0 || isInteger(input)) { |
this is better, right?
| export let factorial = input => { | ||
| // Error If It is Negative, or Not an Integer | ||
| if (sign(input) is -1 || isInteger(input)) { | ||
| fail "Factorial Expects A Non Negative Integer Input" |
There was a problem hiding this comment.
Do we actually want to fail or return an option? @ospencer
There was a problem hiding this comment.
It should fail. If we really don't want it to fail then we can take Jake's suggestion to define this as the gamma function for non-integers.
| fail "Factorial Expects A Non Negative Integer Input" | ||
| } else { | ||
| // Factorial Helper | ||
| let rec fact = n => if (n is 0) 1 else n * fact(n - 1) |
There was a problem hiding this comment.
| let rec fact = n => if (n is 0) 1 else n * fact(n - 1) | |
| let rec fact = n => if (n == 0) 1 else n * fact(n - 1) |
why use is?
| * @param min: The minimum value in the range | ||
| * @param max: The maximum value in the range |
| * | ||
| * @since v0.5.3 | ||
| */ | ||
| export let lerp = (start: Number, end: Number, amount: Number) => { |
There was a problem hiding this comment.
| export let lerp = (start: Number, end: Number, amount: Number) => { | |
| export let linearInterpret = (start: Number, end: Number, amount: Number) => { |
Hear me out. lerp sounds like I'm 🤮
| * | ||
| * @param start: The starting value | ||
| * @param end: The ending value | ||
| * @param amount: an amount between 0 and 1, anything outside the range will produce an extrapolation i.e `lerp(0, 100, 2)` will produce 200 |
There was a problem hiding this comment.
this is a "interpolation" but you are saying that it also "exptrapolates". I don't like that.
|
can someone convert this to a draft pr until #1404 is completed |
|
I think i am going to close this as it will require an entire rewrite to use range and the scope of this pr has changed to just be |
This pr adds
Number.tan,Number.factorial,Number.clamp,Number.lerpto the Number libary for #1017