feat(stdlib)!: List.rotate wraparound for count > length
#1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-snezhko
requested review from
ospencer,
phated,
peblair,
marcusroberts and
jozanza
as code owners
jozanza
approved these changes
Jan 10, 2023
ospencer
approved these changes
Jan 11, 2023
phated
approved these changes
Jan 11, 2023
alex-snezhko
force-pushed
the
list-rotate-wraparound
branch
from
383042a
to
1f1142a
Compare
This was referenced Jan 11, 2023
marcusroberts
pushed a commit
that referenced
this pull request
Jan 14, 2023
This was referenced Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1522
Also allows rotation if positive
countexceeds list length per the spirit of this issue and to match rotation behavior of other data structures (wrapping with the list length).