Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler)!: Make List a language-supplied type #1648

Merged
merged 3 commits into from
Feb 2, 2023
Merged

feat(compiler)!: Make List a language-supplied type #1648

merged 3 commits into from
Feb 2, 2023

Conversation

ospencer
Copy link
Member

@ospencer ospencer commented Feb 1, 2023

Closes #552
Closes #1593

@ospencer ospencer self-assigned this Feb 1, 2023
phated
phated requested changes Feb 2, 2023
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 questions and I think we have a conflict on the generated docs.

stdlib/runtime/string.gr Show resolved Hide resolved
stdlib/runtime/string.gr Show resolved Hide resolved
phated
phated approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks 🎉

@ospencer ospencer merged commit 2ee1328 into main Feb 2, 2023
@ospencer ospencer deleted the oscar/list-language branch February 2, 2023 05:55
@github-actions github-actions bot mentioned this pull request Feb 2, 2023
Merged
@phated phated mentioned this pull request Feb 5, 2023
Closed
@github-actions github-actions bot mentioned this pull request Feb 16, 2023
Closed
This was referenced Mar 20, 2023
Open
Open
av8ta pushed a commit to av8ta/grain that referenced this pull request Apr 11, 2023
@ospencer
feat(compiler)!: Make List a language-supplied type (grain-lang#1648)
771c548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@peblair peblair Awaiting requested review from peblair peblair is a code owner

@jozanza jozanza Awaiting requested review from jozanza jozanza is a code owner

@marcusroberts marcusroberts Awaiting requested review from marcusroberts marcusroberts is a code owner

Assignees

@ospencer ospencer

Labels
None yet
Projects
No open projects
Grain v0.6.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move List type into the language Runtime: Use real list implementation in toString
2 participants
@ospencer @phated