Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(stdlib)!: Group mutable/immutable data structures #1652

Merged
merged 4 commits into from
Mar 15, 2023
Merged

chore(stdlib)!: Group mutable/immutable data structures #1652

merged 4 commits into from
Mar 15, 2023

Conversation

alex-snezhko
Copy link
Member

Groups immutable and mutable versions of the same abstract data types into the same module, with the immutable versions accessible via the Immutable submodule.

Draft because this is still blocked on #1621 and #1644

@alex-snezhko alex-snezhko marked this pull request as ready for review February 22, 2023 04:32
phated
phated requested changes Feb 22, 2023
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a very quick skim but I think we need more updates for @since and @history attributes. I think most of the other changes are just copy-paste to move stuff around, right?

stdlib/priorityqueue.gr Show resolved Hide resolved
stdlib/priorityqueue.gr Outdated Show resolved Hide resolved
stdlib/priorityqueue.gr Show resolved Hide resolved
stdlib/array.gr Outdated Show resolved Hide resolved
stdlib/array.gr Show resolved Hide resolved
stdlib/array.gr Show resolved Hide resolved
phated
phated reviewed Mar 15, 2023
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes that I'm going to accept then regen the docs and do any formatting so we can land this.

stdlib/array.gr Outdated Show resolved Hide resolved
stdlib/map.gr Outdated Show resolved Hide resolved
stdlib/map.gr Outdated Show resolved Hide resolved
stdlib/map.gr Show resolved Hide resolved
stdlib/map.gr Show resolved Hide resolved
stdlib/priorityqueue.gr Outdated Show resolved Hide resolved
stdlib/set.gr Outdated Show resolved Hide resolved
phated
phated approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phated phated added this pull request to the merge queue Mar 15, 2023
Merged via the queue into grain-lang:main with commit f93afef Mar 15, 2023
This was referenced Mar 15, 2023
Merged
Closed
Open
Open
av8ta pushed a commit to av8ta/grain that referenced this pull request Apr 11, 2023
@alex-snezhko @phated
chore(stdlib)!: Group mutable/immutable data structures (grain-lang#1652
a8aa0d6 
)

* chore(stdlib)!: Group mutable/immutable data structures

* add submodule tests into submodule within test files

* Apply suggestions from code review

* Regen docs

---------

Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@peblair peblair Awaiting requested review from peblair peblair is a code owner

@marcusroberts marcusroberts Awaiting requested review from marcusroberts marcusroberts is a code owner

@jozanza jozanza Awaiting requested review from jozanza jozanza is a code owner

@ospencer ospencer Awaiting requested review from ospencer ospencer is a code owner

Assignees

@alex-snezhko alex-snezhko

Labels
None yet
Projects
No open projects
Grain v0.6.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex-snezhko @phated @ospencer