feat(compiler)!: Remove 32-bit numbers from Number type
#1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-snezhko
requested review from
ospencer,
peblair,
jozanza,
phated and
marcusroberts
as code owners
ospencer
requested changes
Feb 19, 2023
ospencer
reviewed
Feb 20, 2023
alex-snezhko
force-pushed
the
remove-32-bit-from-num
branch
from
6ac1012
to
e3a33be
Compare
alex-snezhko
force-pushed
the
remove-32-bit-from-num
branch
from
e3a33be
to
994de28
Compare
phated
requested changes
Feb 25, 2023
alex-snezhko
force-pushed
the
remove-32-bit-from-num
branch
from
994de28
to
0d033db
Compare
alex-snezhko
force-pushed
the
remove-32-bit-from-num
branch
from
0d033db
to
f5b1fa2
Compare
phated
approved these changes
Feb 26, 2023
This was referenced Feb 26, 2023
This was referenced Mar 20, 2023
av8ta
pushed a commit
to av8ta/grain
that referenced
this pull request
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1555, making
Int32andFloat32their own distinct types separate fromNumber. The most fragile part of these changes is making sure that all of the memory load offsets for these types were corrected, but I am fairly confident that I got them all after sweeping through every instance of8nin the stdlib/runtime several times and making corrections where necessary 🤞 .