feat(stdlib)!: Add ** (pow) operator to Pervasives module
#1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
peblair,
jozanza,
phated and
marcusroberts
as code owners
phated
reviewed
Feb 21, 2023
spotandjake
force-pushed
the
spotandjake-power-runtime
branch
from
5a3a5cb
to
23b043e
Compare
phated
changed the title
** (pow) operator to Pervasives module
phated
reviewed
Feb 22, 2023
stdlib/pervasives.md
Outdated
| @@ -482,6 +482,39 @@ Returns: | |||
| |----|-----------| | |||
| |`Number`|The modulus of its operands| | |||
|
|
|||
| ### Pervasives.**(**)** | |||
There was a problem hiding this comment.
This shouldn't be your fault, but this doesn't seem to be escaped correctly. Not sure what is happening.
There was a problem hiding this comment.
I've merged in main to see if the graindoc is out of date.
There was a problem hiding this comment.
I specifically rebuilt the compiler and regen'd the docs before pushing the last region commit so that probably isn't the case.
There was a problem hiding this comment.
You are correct. Markdown.bold wasn't being used in all the cases where we were bolding things 🤦
There was a problem hiding this comment.
Fixed in main since #1695 landed
|
Regenerated the docs, your fix looks to have worked now. |
phated
approved these changes
Feb 22, 2023
This was referenced Feb 22, 2023
This was referenced Mar 20, 2023
av8ta
pushed a commit
to av8ta/grain
that referenced
this pull request
Apr 11, 2023
…ng#1690) * feat!: Move `Number.Pow` To Runtime and add operator to pervasives * chore: Regen Docs * chore: Regen Tests * chore: Update Grain Doc * chore: Regen Docs --------- Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr moves power to the runtime and adds pervasives as an operator. I didnt see anywhere to test the operator or functions in the runtime but power is well tested in the number test suite.
As I noted in discord I decided to just remake this pr as all the tests changed there were a ton of merge of conflicts and this made things easier. Replaces: #1538
Closes: #1476