feat(stdlib)!: Convert unsafe Wasm functions to operators
#1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
force-pushed
the
spotandjake-fix-wasm-style
branch
2 times, most recently
from
44de3b7
to
ec0ea2b
Compare
spotandjake
commented
Mar 7, 2023
| ) { | ||
| from WasmI64 use { (>>), (<), (>) } | ||
| // TODO(#1736): Remove the formatter ignore when parsing is fixed | ||
| //formatter-ignore |
There was a problem hiding this comment.
If #1736 gets patched before this is merged then this should be removed.
spotandjake
force-pushed
the
spotandjake-fix-wasm-style
branch
from
ec0ea2b
to
44a6e2e
Compare
spotandjake
changed the title
Wasm calls to operatorsWasm calls to operators
spotandjake
changed the title
Wasm calls to operatorsWasm calls to operators
spotandjake
requested review from
ospencer,
peblair,
jozanza,
phated and
marcusroberts
as code owners
ospencer
reviewed
Mar 11, 2023
spotandjake
force-pushed
the
spotandjake-fix-wasm-style
branch
from
b7c18a2
to
ee0292d
Compare
ospencer
reviewed
Apr 6, 2023
ospencer
changed the title
Wasm calls to operatorsWasm functions to operators
ospencer
approved these changes
Apr 6, 2023
av8ta
pushed a commit
to av8ta/grain
that referenced
this pull request
Apr 11, 2023
…ng#1734) * feat!: Move `WasmF32` to operators * feat: Move `WasmF64` to operators * feat: Move `WasmI64` to operators * Feat: `WasmI32` to operators * chore: Update tests and docs * chore: Undo Global Scope's * chore: Apply suggestions from code review * fix: mistake in rebase * chore: Revert changes to `package-lock`
av8ta
pushed a commit
to av8ta/grain
that referenced
this pull request
Apr 18, 2023
…ng#1734) * feat!: Move `WasmF32` to operators * feat: Move `WasmF64` to operators * feat: Move `WasmI64` to operators * Feat: `WasmI32` to operators * chore: Update tests and docs * chore: Undo Global Scope's * chore: Apply suggestions from code review * fix: mistake in rebase * chore: Revert changes to `package-lock`
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr changes the names of some of the Wasm Unsafe Runtime Operations such as
WasmI32.addto be operators instead.Currently Completed is
WasmF32andWasmF64Breaking: This is breaking because we are chaining the module apis.
This is a Draft because I still have todo
WasmI32andWasmI64.