feat(ci): Add builds for preview binaries #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
approved these changes
Mar 22, 2023
This was referenced Mar 22, 2023
av8ta
pushed a commit
to av8ta/grain
that referenced
this pull request
Apr 11, 2023
* feat(ci): Add builds for preview binaries * chore(ci): Update actions * chore(ci): Only run the CI workflow on PR, merge_group, and push-to-main * document decision * Remove seemingly unnecessary string quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Release workflow to generate "preview" binaries whenever the Release Please updates the release PR. It also uses that binary to regenerate and push the docs on the release branch, which triggers a CI run necessary for us to merge the release in the queue.
I refactored the workflow a bit so we use the same logic to build and upload the binaries with the same workflow. This should allow us to be more confident the release flow will happen successfully since the previews are built often.
I didn't get around to adding workflow_dispatch so we could run these in isolation, which is mostly because we rely on the binary being an artifact of a run. We might need to combine some reusable workflows into a dispatch, but I'm not sure yet.