-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graindoc): Allow doc comments on variants and record fields #1852
Conversation
Excited to look at this! I'm pretty sure you need to add tests now that @spotandjake added the test harness |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, I love how much it cleaner it makes the docs. I just had two little notes to keep the tables in line with the function tables but besides that it looks good.
Also after this is merged someone will need to update the website docs on this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but holding off on an approval until @spotandjake's comments are addressed
cbf598e
to
c9299df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the nested table so I proposed an alternative. Also had a question about levels and a possible bug (that we should fix and add a test for).
7df8075
to
de36ef2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the output a lot! I had just a couple comments on the implementation
de36ef2
to
862d684
Compare
Closes #992