Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stdlib)!: Reorder parameters to List.insert #1857

Merged
merged 3 commits into from
Jul 1, 2023
Merged

feat(stdlib)!: Reorder parameters to List.insert #1857

merged 3 commits into from
Jul 1, 2023

Conversation

alex-snezhko
Copy link
Member

Closes #1856

spotandjake
spotandjake approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@spotandjake spotandjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though you forgot to regain the grain doc.

jozanza
jozanza approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@jozanza jozanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cool with this

phated
phated requested changes Jun 25, 2023
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a history entry

@phated phated changed the title feat(stdlib)!: Adjust List.insert param order feat(stdlib)!: Reorder parameters to List.insert Jul 1, 2023
@phated phated added this pull request to the merge queue Jul 1, 2023
Merged via the queue into grain-lang:main with commit 973f3f3 Jul 1, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jozanza jozanza jozanza approved these changes

@phated phated phated approved these changes

@peblair peblair peblair approved these changes

@ospencer ospencer ospencer approved these changes

@marcusroberts marcusroberts marcusroberts approved these changes

@spotandjake spotandjake spotandjake approved these changes

Assignees

@alex-snezhko alex-snezhko

Labels
stdlib
Projects
No open projects
Grain v0.6.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change List.insert parameter order for consistency
7 participants
@alex-snezhko @jozanza @phated @peblair @ospencer @marcusroberts @spotandjake