fix(stdlib): Properly handle extremely large integer bases in Number.(**)
#1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
peblair,
jozanza,
phated and
marcusroberts
as code owners
|
@spotandjake can you please update the PR title to be a |
spotandjake
changed the title
Number.(**) functionNumber.(**) with regard to extremely high integer bases
spotandjake
changed the title
Number.(**) with regard to extremely high integer basesNumber.(**) with regard to extremely large integer bases
made that change |
alex-snezhko
approved these changes
Jan 24, 2024
phated
changed the title
Number.(**) with regard to extremely large integer basesNumber.(**) with regard to extremely large integer bases
phated
changed the title
Number.(**) with regard to extremely large integer basesNumber.(**)
phated
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr cleans up a tiny bit in
Number.powit also fixes a small edge case mistake, and adds a regression test.edit:
The bug was introduced during the refactor to use early return, for extremely high powers done on floating point bases we were previously returning the
zvariable which is an internal variable rather than output which caused the awnsers to be incorrect.