feat(compiler): Enable single-file compilation #2105
+28,128
−53,213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
requested review from
peblair,
phated,
alex-snezhko and
marcusroberts
as code owners
ospencer
force-pushed
the
oscar/gro-linking
branch
from
c328d9c
to
92e6423
Compare
ospencer
force-pushed
the
oscar/gro-linking
branch
from
92e6423
to
89fcb11
Compare
ospencer
force-pushed
the
oscar/dependency-refactor
branch
3 times, most recently
from
b9bfd14
to
7039e88
Compare
ospencer
force-pushed
the
oscar/dependency-refactor
branch
from
7039e88
to
6e314ce
Compare
marcusroberts
approved these changes
Aug 8, 2024
ospencer
force-pushed
the
oscar/gro-linking
branch
from
193e5ec
to
6ac38da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the
DependenciesCompiled,ObjectsLinked,Compiled, andAssembledstates out ofcompile.reand introduces thegraincflag--single-fileto compile a single dependency. The linker is now completely separate from the process of compilation—compiling a file now only means converting source code into an object file. Linking is the combining a number of object files into a wasm file (andgraincwill still do both compiling and linking). This allows build tools to handle compilation and linking separately.The future plan is to make single file mode the default once we have a build tool managing building projects (
silo). I'm not sure that we should get rid of the dependency compilation entirely since it would be useful for development, but that's a decision for later.