Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stdlib)!: Use random seed for hash module #854

Merged
merged 1 commit into from
Sep 6, 2021
Merged

fix(stdlib)!: Use random seed for hash module #854

merged 1 commit into from
Sep 6, 2021

Conversation

ospencer
Copy link
Member

@ospencer ospencer commented Sep 4, 2021

No description provided.

@ospencer ospencer requested a review from a team September 4, 2021 19:30
@ospencer ospencer self-assigned this Sep 4, 2021
phated
phated approved these changes Sep 4, 2021
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a breaking fix because there would be a tiny chance that someone was reliant on consistent hashes between runs (They shouldn't have been, but just maybe?)

@ospencer
Copy link
Member Author

ospencer commented Sep 4, 2021

Maybe? But we can mark it breaking just in case :)

@ospencer ospencer changed the title fix(stdlib): Use random seed for hash module fix(stdlib)!: Use random seed for hash module Sep 4, 2021
marcusroberts
marcusroberts approved these changes Sep 4, 2021
View reviewed changes
Copy link
Member

@marcusroberts marcusroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@phated phated requested a review from jozanza September 6, 2021 19:47
@ospencer ospencer merged commit a1a42d8 into main Sep 6, 2021
@ospencer ospencer deleted the oscar/fix-hash-seed branch September 6, 2021 20:36
@github-actions github-actions bot mentioned this pull request Sep 6, 2021
Merged
@github-actions github-actions bot mentioned this pull request Jul 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusroberts marcusroberts marcusroberts approved these changes

@peblair peblair peblair approved these changes

@phated phated phated approved these changes

@jozanza jozanza jozanza approved these changes

Assignees

@ospencer ospencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ospencer @jozanza @phated @peblair @marcusroberts