fix(grainfmt): Remove extraneous parens around infix function application #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
reviewed
Sep 19, 2021
marcusroberts
commented
Sep 20, 2021
ospencer
reviewed
Sep 20, 2021
Co-authored-by: Oscar Spencer <oscar@grain-lang.org>
|
I have much better confidence in this version as I'm using operator precedence and making the comparison in the right place. Quite a few tests too. |
ospencer
reviewed
Sep 21, 2021
phated
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #859
The formatter was cautiously adding parens around too many infix function application parameters.
This has been fixed. The formatter still adds some redundant parens, e.g.
3 + (4 * 5) can be simplified to 3 + 4 * 5
which I will fix in another PR where we take operator precedence into account