provide isError and use it in place of instanceof Error

Fixes angular#15868
graingert · Mar 30, 2017 · 0061c54 · 0061c54
1 parent f403925
commit 0061c54
Show file tree

Hide file tree

Showing 9 changed files with 68 additions and 5 deletions.
diff --git a/src/.eslintrc.json b/src/.eslintrc.json
@@ -50,6 +50,7 @@
     "isNumber": false,
     "isNumberNaN": false,
     "isDate": false,
+    "isError": false,
     "isArray": false,
     "isFunction": false,
     "isRegExp": false,

diff --git a/src/Angular.js b/src/Angular.js
@@ -45,6 +45,7 @@
   isNumber,
   isNumberNaN,
   isDate,
+  isError,
   isArray,
   isFunction,
   isRegExp,
@@ -673,6 +674,28 @@ function isDate(value) {
  */
 var isArray = Array.isArray;
 
+/**
+ * @ngdoc function
+ * @name angular.isError
+ * @module ng
+ * @kind function
+ *
+ * @description
+ * Determines if a reference is an `Error`.
+ *
+ * @param {*} value Reference to check.
+ * @returns {boolean} True if `value` is an `Error`.
+ */
+function isError(value) {
+  var tag = toString(value);
+  switch (tag) {
+    case '[object Error]': return true;
+    case '[object Exception]': return true;
+    case '[object DOMException]': return true;
+    default: return value instanceof Error;
+  }
+}
+
 /**
  * @ngdoc function
  * @name angular.isFunction

diff --git a/src/ng/compile.js b/src/ng/compile.js
@@ -3098,7 +3098,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
           }
           linkQueue = null;
         }).catch(function(error) {
-          if (error instanceof Error) {
+          if (isError(error)) {
             $exceptionHandler(error);
           }
         });

diff --git a/src/ng/log.js b/src/ng/log.js
@@ -132,7 +132,7 @@ function $LogProvider() {
     };
 
     function formatError(arg) {
-      if (arg instanceof Error) {
+      if (isError(arg)) {
         if (arg.stack && formatStackTrace) {
           arg = (arg.message && arg.stack.indexOf(arg.message) === -1)
               ? 'Error: ' + arg.message + '\n' + arg.stack

diff --git a/src/ng/q.js b/src/ng/q.js
@@ -381,7 +381,7 @@ function qFactory(nextTick, exceptionHandler, errorOnUnhandledRejections) {
       if (!toCheck.pur) {
         toCheck.pur = true;
         var errorMessage = 'Possibly unhandled rejection: ' + toDebugString(toCheck.value);
-        if (toCheck.value instanceof Error) {
+        if (isError(toCheck.value)) {
           exceptionHandler(toCheck.value, errorMessage);
         } else {
           exceptionHandler(errorMessage);

diff --git a/src/ngMock/angular-mocks.js b/src/ngMock/angular-mocks.js
@@ -984,7 +984,7 @@ angular.mock.dump = function(object) {
     } else if (angular.isObject(object)) {
       if (angular.isFunction(object.$eval) && angular.isFunction(object.$apply)) {
         out = serializeScope(object);
-      } else if (object instanceof Error) {
+      } else if (angular.isError(object)) {
         out = object.stack || ('' + object.name + ': ' + object.message);
       } else {
         // TODO(i): this prevents methods being logged,

diff --git a/test/.eslintrc.json b/test/.eslintrc.json
@@ -64,6 +64,7 @@
     "isNumber": false,
     "isNumberNaN": false,
     "isDate": false,
+    "isError": false,
     "isArray": false,
     "isFunction": false,
     "isRegExp": false,

diff --git a/test/AngularSpec.js b/test/AngularSpec.js
@@ -1861,6 +1861,44 @@ describe('angular', function() {
     });
   });
 
+  describe('isError', function() {
+    it('should not assume objects are errors', function() {
+      expect(isError({ message: 'A fake error', stack: 'no stack here'}))
+        .toBe(false);
+    });
+
+    it('should detect simple error instances', function() {
+      expect(isError(new Error()).toBe(true));
+    });
+
+    function testError(createError) {
+      var iframe = document.createElement('iframe');
+      document.body.appendChild(iframe);
+      try {
+        var error = createError(iframe.contentWindow);
+        expect(error instanceof Error).toBe(false);
+        expect(isError(error)).toBe(true);
+      } finally {
+        iframe.parentElement.removeChild(iframe);
+      }
+    }
+
+    it('should detect errors from another context', function() {
+      testError(function(win) {
+        return new win.Error();
+      });
+    });
+
+    it('should detect DOMException errors from another context', function() {
+      testError(function(win) {
+        try {
+          win.document.querySelectorAll('');
+        } catch (e) {
+          return e;
+        }
+      });
+    });
+  });
 
   describe('isRegExp', function() {
     it('should return true for RegExp object', function() {

diff --git a/test/ng/qSpec.js b/test/ng/qSpec.js
@@ -37,7 +37,7 @@ describe('q', function() {
   // The following private functions are used to help with logging for testing invocation of the
   // promise callbacks.
   function _argToString(arg) {
-    return (typeof arg === 'object' && !(arg instanceof Error)) ? toJson(arg) : '' + arg;
+    return (typeof arg === 'object' && !(isError(arg))) ? toJson(arg) : '' + arg;
   }
 
   function _argumentsToString(args) {