Change the license of all examples to BSD-3-clause #90
Conversation
There was a problem hiding this comment.
Reviewed 27 of 27 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @dimakuv)
-- commits line 2 at r1:
Should follow the update of the PR in core Gramine repo
Code quote:
Add the BSD-3-clause license to all examples
-- commits line 14 at r1:
ditto
Code quote:
prevoiusly
LICENSE.txt line 1 at r1 (raw file):
Copyright 2023 GSC Contributors
-> Gramine
Code quote:
GSC
There was a problem hiding this comment.
Reviewable status: all files reviewed, 4 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel)
a discussion (no related file):
To change the license from LGPL, need acknowledgements from contributors of examples (people who contributed significant changes):
- @dimakuv (myself, I acknowledge)
- @monavij (on behalf of Thomas Knauth, who doesn't work at Intel anymore)
- @vijaydhanraj
- @jkr0103
- @chiache
- @mkow
- @pangzi85480 (aka
jack.wxz) - @anjalirai-intel
The list is partially taken from this first commit: f55dc0d. And by manually inspecting other commits.
dimakuv
force-pushed
the
dimakuv/add-bsd-license-to-examples
branch
from
402d394 to
1524dc0
Compare
There was a problem hiding this comment.
Reviewable status: 26 of 27 files reviewed, 4 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @kailun-qin)
a discussion (no related file):
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
To change the license from LGPL, need acknowledgements from contributors of examples (people who contributed significant changes):
- @dimakuv (myself, I acknowledge)
- @monavij (on behalf of Thomas Knauth, who doesn't work at Intel anymore)
- @vijaydhanraj
- @jkr0103
- @chiache
- @mkow
- @pangzi85480 (aka
jack.wxz)- @anjalirai-intel
The list is partially taken from this first commit: f55dc0d. And by manually inspecting other commits.
All the listed above people (or their managers), could you please acknowledge that you're Ok with having an explicit BSD-3-clause license?
Previously, kailun-qin (Kailun Qin) wrote…
Should follow the update of the PR in core Gramine repo
Done.
Previously, kailun-qin (Kailun Qin) wrote…
ditto
Done.
LICENSE.txt line 1 at r1 (raw file):
Previously, kailun-qin (Kailun Qin) wrote…
->
Gramine
Done. Yeah, copy-paste fail.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel)
There was a problem hiding this comment.
Reviewed 26 of 27 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
dimakuv
changed the title
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions
a discussion (no related file):
@pangzi85480 You contributed to one of the examples in this repository, could you write that you ACK (acknowledge) the change of the license on your example from LGPL to BSD?
There was a problem hiding this comment.
Reviewed 26 of 27 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @anjalirai-intel, @chiache, @dimakuv, @jkr0103, @monavij, @pangzi85480, and @vijaydhanraj)
a discussion (no related file):
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
All the listed above people (or their managers), could you please acknowledge that you're Ok with having an explicit BSD-3-clause license?
ACK
curl/curl.manifest.template line 2 at r2 (raw file):
# Copyright (C) 2024 Gramine contributors # # SPDX-License-Identifier: BSD-3-Clause
duplicated #
curl/Makefile line 2 at r2 (raw file):
# Copyright (C) 2024 Gramine contributors # # SPDX-License-Identifier: BSD-3-Clause
Duplicated #
There was a problem hiding this comment.
Reviewable status: 25 of 27 files reviewed, 4 unresolved discussions, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel), "fixup! " found in commit messages' one-liners (waiting on @anjalirai-intel, @chiache, @jkr0103, @kailun-qin, @mkow, @monavij, @pangzi85480, @vijaydhanraj, and @woju)
curl/curl.manifest.template line 2 at r2 (raw file):
Previously, mkow (Michał Kowalczyk) wrote…
duplicated
#
Done.
curl/Makefile line 2 at r2 (raw file):
Previously, mkow (Michał Kowalczyk) wrote…
Duplicated
#
Done.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions, "fixup! " found in commit messages' one-liners (waiting on @anjalirai-intel, @chiache, @jkr0103, @monavij, @pangzi85480, and @vijaydhanraj)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions, "fixup! " found in commit messages' one-liners (waiting on @anjalirai-intel, @chiache, @monavij, @pangzi85480, and @vijaydhanraj)
There was a problem hiding this comment.
Reviewed 24 of 27 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions, "fixup! " found in commit messages' one-liners (waiting on @anjalirai-intel, @chiache, @monavij, @pangzi85480, and @vijaydhanraj)
|
LGTM |
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions, "fixup! " found in commit messages' one-liners (waiting on @chiache, @monavij, @pangzi85480, and @vijaydhanraj)
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions, "fixup! " found in commit messages' one-liners (waiting on @chiache, @monavij, @pangzi85480, and @vijaydhanraj)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions, "fixup! " found in commit messages' one-liners (waiting on @anjalirai-intel, @chiache, @pangzi85480, and @vijaydhanraj)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions, "fixup! " found in commit messages' one-liners (waiting on @anjalirai-intel, @chiache, @monavij, and @pangzi85480)
a discussion (no related file):
Previously, mkow (Michał Kowalczyk) wrote…
ACK
ACK
There was a problem hiding this comment.
Reviewed 23 of 27 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions, "fixup! " found in commit messages' one-liners (waiting on @anjalirai-intel, @monavij, and @pangzi85480)
|
LGTM |
The examples had the default license of LGPL-3.0. With this commit, we change the license of all Makefiles, manifest templates, config files, and some scripts in examples to a BSD-3-clause license. This change is permitted by the "Examples Exception" to the Technical Charter, enacted on 5. December 2023. This change was agreed by all contributors to examples, past and present. This change is in response to a popular request to adopt a more permissive license for our examples. The new BSD-3-clause is a permissive license (in contrast to the previously applied copyleft LGPL license). BSD explicitly allows to modify and use our examples without any obligation to share these modifications. This commit is a counterpart to the commit "[CI-Examples] Change the license of all examples to BSD-3-clause" in the core Gramine repo. Signed-off-by: Dmitrii Kuvaiskii <dmitrii.kuvaiskii@intel.com>
There was a problem hiding this comment.
Reviewable status: all files reviewed, all discussions resolved, "fixup! " found in commit messages' one-liners
a discussion (no related file):
Previously, vijaydhanraj (Vijay Dhanraj) wrote…
ACK
All required persons acknowledged the license change, now we can proceed and merge this PR.
a discussion (no related file):
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
@pangzi85480 You contributed to one of the examples in this repository, could you write that you ACK (acknowledge) the change of the license on your example from LGPL to BSD?
Done (see other comment)
dimakuv
force-pushed
the
dimakuv/add-bsd-license-to-examples
branch
from
d5d7236 to
17f7706
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:
The examples had the default license of LGPL-3.0. With this commit, we change the license of all Makefiles, manifest templates, config files, and some scripts in examples to a BSD-3-clause license.
This change is permitted by the "Examples Exception" to the Technical Charter, enacted on 5. December 2023. This change was agreed by all contributors to examples, past and present.
This change is in response to a popular request to adopt a more permissive license for our examples. The new BSD-3-clause is a permissive license (in contrast to the prevoiusly applied copyleft LGPL license). BSD explicitly allows to modify and use our examples without any obligation to share these modifications.
This commit is a counterpart to the commit "[CI-Examples] Add the BSD-3-clause license to all examples" in the core Gramine repo. See gramineproject/gramine#1657.
For details, see also:
This change is