Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI-Examples] Add Nginx test data files measurements within the manifest #2018

Merged

Commits on Oct 16, 2024

  1. [CI-Examples] Add Nginx test data files to the manifest

    Commit aef087f "[LibOS] Move trusted and allowed files logic to LibOS"
    incorrectly modified Makefile of the Nginx example. The test data files
    (automatically generated by Makefile and put under Nginx install dir
    `install/html/random`) got generated after the Gramine manifest
    expansion. This led to those test files not being added as
    `sgx.trusted_files` to the manifest, and Nginx server could not retrieve
    them and thus returned error code 403 ("Forbidden"). The fix is simple:
    move the `$TEST_DATA` variable before the `nginx.manifest` target (which
    already has `$TEST_DATA` as its dependency).
    
    This bug was not detected by our CI because the Nginx test uses `wrk`
    which ignores error code 403 and happily counts this error response
    towards its total stats. This needs to be fixed in a separate commit.
    
    Signed-off-by: Vasanth Nagaraja <vasanth.k.nagaraja@intel.com>
    vasanth-intel authored and dimakuv committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    42251d8 View commit details
    Browse the repository at this point in the history