[CI] Ubuntu 24.04 and 22.04 part 3/? #2028
Conversation
|
Jenkins, test this please |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required) (waiting on @woju)
-- commits line 51 at r3:
Not blocking, but this commit message contains a ton of unnecessary info. Why not simply:
[LibOS/tests] Fix openmp manifest to add shm tmpfs
There is a known issue in some versions of `libomp` (the
LLVM implementation of OpenMP), and probably also in `libiomp` (Intel
implementation of OpenMP). Those versions require /dev/shm to
exist. This commit modifies the openmp manifest to add this dir as a
tmpfs mount. With this fix, the files under /dev/shm/ are not visible on
the host, so security of the application remains intact.
Based on the suggestion by Dmitrii Kuvaiskii. See
https://github.com/gramineproject/gramine/discussions/1780#discussioncomment-8589083
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dimakuv)
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
Not blocking, but this commit message contains a ton of unnecessary info. Why not simply:
[LibOS/tests] Fix openmp manifest to add shm tmpfs There is a known issue in some versions of `libomp` (the LLVM implementation of OpenMP), and probably also in `libiomp` (Intel implementation of OpenMP). Those versions require /dev/shm to exist. This commit modifies the openmp manifest to add this dir as a tmpfs mount. With this fix, the files under /dev/shm/ are not visible on the host, so security of the application remains intact. Based on the suggestion by Dmitrii Kuvaiskii. See https://github.com/gramineproject/gramine/discussions/1780#discussioncomment-8589083
+1 (for not leaving my wrong suggestion in the commit msg) :)
woju
force-pushed
the
woju/noble-stack-2
branch
from
5a6b8a1
to
137e7cc
Compare
There was a problem hiding this comment.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @dimakuv and @kailun-qin)
Previously, kailun-qin (Kailun Qin) wrote…
+1 (for not leaving my wrong suggestion in the commit msg) :)
Done.
:)
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 1 of 1 files at r2, 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
Signed-off-by: Wojtek Porczyk <woju@invisiblethingslab.com>
- Make wrk2 dependency optional. The wrk2 tool adds -R option to wrk tool, however, wrk2 is not packaged for Debian/Ubuntu, but wrk is. If wrk2 is not available, then we can just use vanilla wrk tool. - Convert bc arithmetic to python3 -c. This removes bc dependency in favour of python3, which is always available, because it's a dependency of both Gramine tooling and build system. (POSIX shell arithmetic substitution does not support decimal, so it's not suitable). Signed-off-by: Wojtek Porczyk <woju@invisiblethingslab.com>
Signed-off-by: Wojtek Porczyk <woju@invisiblethingslab.com>
There is a known issue in some versions of `libomp` (the LLVM implementation of OpenMP), and probably also in `libiomp` (Intel implementation of OpenMP). Those versions require /dev/shm to exist. This commit modifies the openmp manifest to add this dir as a tmpfs mount. With this fix, the files under /dev/shm/ are not visible on the host, so security of the application remains intact. Based on the suggestion by Dmitrii Kuvaiskii. See #1780 (comment) Signed-off-by: Wojtek Porczyk <woju@invisiblethingslab.com>
woju
force-pushed
the
woju/noble-stack-2
branch
from
137e7cc
to
16d076d
Compare
There was a problem hiding this comment.
Reviewed 1 of 7 files at r6, 4 of 4 files at r7, 1 of 1 files at r8, 1 of 1 files at r9, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)
There was a problem hiding this comment.
Reviewed 7 of 7 files at r6, 4 of 4 files at r7, 1 of 1 files at r8, 1 of 1 files at r9, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 6 of 7 files at r6, 4 of 4 files at r7, 1 of 1 files at r8, 1 of 1 files at r9, all commit messages.
Reviewable status:
Description of the changes
See #2026 for rationale
How to test this PR?
CI
This change is