Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Ubuntu 24.04 and 22.04 part 4/? #2029

Merged
merged 2 commits into from
Oct 16, 2024
Merged

[CI] Ubuntu 24.04 and 22.04 part 4/? #2029

merged 2 commits into from
Oct 16, 2024

Conversation

woju
Copy link
Member

@woju woju commented Oct 14, 2024

Description of the changes

See #2026 for rationale

How to test this PR?

CI


This change is Reviewable

@woju
Copy link
Member Author

woju commented Oct 15, 2024

Jenkins, test Jenkins-SGX-20.04-apps please

Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @woju)


-- commits line 10 at r2:
pipe -> pipe04


.ci/ubuntu22.04.dockerfile line 53 at r1 (raw file):

# gdb: tested in libos suite
# ncat: used in scripts/wait_for_server
# linux-libc-dev: among others, needed to compile busybox (CI-Examples/busybox)

That's wrong now, after we merged this commit: e9cab24

I don't mind keeping this package, seems important anyway, but I would change the comment to something more generic


.ci/ubuntu22.04.dockerfile line 61 at r1 (raw file):

# sqlite3: CI-Examples/sqlite
# libsgx-*: CI-Examples/ra-tls-*
# curl: CI-Examples/ra-tls-secret-prov

Out of curiosity -- why is this list not sorted?


.ci/ubuntu24.04.dockerfile line 54 at r1 (raw file):

# gdb: tested in libos suite
# ncat: used in scripts/wait_for_server
# linux-libc-dev: among others, needed to compile busybox (CI-Examples/busybox)

ditto

Copy link
Member Author

@woju woju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 6 files reviewed, 4 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @dimakuv)


-- commits line 10 at r2:

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

pipe -> pipe04

Done.


.ci/ubuntu22.04.dockerfile line 53 at r1 (raw file):

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

That's wrong now, after we merged this commit: e9cab24

I don't mind keeping this package, seems important anyway, but I would change the comment to something more generic

No, I think it shouldn't be there at all, if we don't need it.


.ci/ubuntu22.04.dockerfile line 61 at r1 (raw file):

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

Out of curiosity -- why is this list not sorted?

Historical reason, I've been adding stuff to it. Fixed.


.ci/ubuntu24.04.dockerfile line 54 at r1 (raw file):

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

ditto

Ditto.

Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 5 of 5 files at r4, 1 of 1 files at r5, 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @dimakuv)

dimakuv
dimakuv previously approved these changes Oct 15, 2024
Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 5 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

kailun-qin
kailun-qin previously approved these changes Oct 15, 2024
Copy link
Contributor

@kailun-qin kailun-qin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 2 of 5 files at r4, 1 of 1 files at r5, 2 of 2 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

- epoll01:          300 s -> skip
- pipe04:            30 s -> 60 s
- clock_gettime04: disable test 1

Signed-off-by: Wojtek Porczyk <woju@invisiblethingslab.com>
For some reason memcached-tool sometimes outputs more than 2 lines,
which still means that there is data in the server, so it's working.

Signed-off-by: Wojtek Porczyk <woju@invisiblethingslab.com>
mkow
mkow previously approved these changes Oct 15, 2024
Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r7, 5 of 5 files at r8, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Base automatically changed from woju/noble-stack-2 to master October 15, 2024 20:46
@woju woju dismissed stale reviews from mkow, kailun-qin, and dimakuv October 15, 2024 20:46

The base branch was changed.

Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL)

Copy link
Contributor

@kailun-qin kailun-qin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r8, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mkow mkow merged commit 9d51894 into master Oct 16, 2024
20 of 34 checks passed
@mkow mkow deleted the woju/noble-stack-3 branch October 16, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants