-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Ubuntu 24.04 and 22.04 part 4/? #2029
Conversation
Jenkins, test Jenkins-SGX-20.04-apps please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @woju)
-- commits
line 10 at r2:
pipe
-> pipe04
.ci/ubuntu22.04.dockerfile
line 53 at r1 (raw file):
# gdb: tested in libos suite # ncat: used in scripts/wait_for_server # linux-libc-dev: among others, needed to compile busybox (CI-Examples/busybox)
That's wrong now, after we merged this commit: e9cab24
I don't mind keeping this package, seems important anyway, but I would change the comment to something more generic
.ci/ubuntu22.04.dockerfile
line 61 at r1 (raw file):
# sqlite3: CI-Examples/sqlite # libsgx-*: CI-Examples/ra-tls-* # curl: CI-Examples/ra-tls-secret-prov
Out of curiosity -- why is this list not sorted?
.ci/ubuntu24.04.dockerfile
line 54 at r1 (raw file):
# gdb: tested in libos suite # ncat: used in scripts/wait_for_server # linux-libc-dev: among others, needed to compile busybox (CI-Examples/busybox)
ditto
5a6b8a1
to
137e7cc
Compare
b7c3499
to
6cf353c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 6 files reviewed, 4 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @dimakuv)
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
pipe
->pipe04
Done.
.ci/ubuntu22.04.dockerfile
line 53 at r1 (raw file):
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
That's wrong now, after we merged this commit: e9cab24
I don't mind keeping this package, seems important anyway, but I would change the comment to something more generic
No, I think it shouldn't be there at all, if we don't need it.
.ci/ubuntu22.04.dockerfile
line 61 at r1 (raw file):
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
Out of curiosity -- why is this list not sorted?
Historical reason, I've been adding stuff to it. Fixed.
.ci/ubuntu24.04.dockerfile
line 54 at r1 (raw file):
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
ditto
Ditto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 5 of 5 files at r4, 1 of 1 files at r5, 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @dimakuv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 5 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
137e7cc
to
16d076d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 2 of 5 files at r4, 1 of 1 files at r5, 2 of 2 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
- epoll01: 300 s -> skip - pipe04: 30 s -> 60 s - clock_gettime04: disable test 1 Signed-off-by: Wojtek Porczyk <woju@invisiblethingslab.com>
For some reason memcached-tool sometimes outputs more than 2 lines, which still means that there is data in the server, so it's working. Signed-off-by: Wojtek Porczyk <woju@invisiblethingslab.com>
6cf353c
to
9d51894
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r7, 5 of 5 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
The base branch was changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
Description of the changes
See #2026 for rationale
How to test this PR?
CI
This change is