Refactor sysfs to improve sanitization - Part 3 #360
Conversation
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @vijaydhanraj)
-- commits, line 7 at r1:
and unify (you forgot and)
-- commits, line 8 at r1:
PAL -> PALs
|
Jenkins, test this please |
vijaydhanraj
force-pushed
the
vdhanraj/refactor_sysfs_part3
branch
from
8af10dd to
e820bb0
Compare
There was a problem hiding this comment.
Reviewable status: all files reviewed, 4 unresolved discussions, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @dimakuv)
-- commits, line 6 at r1:
Also, fixed Linux_SGX->Linux-SGX
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
and unify(you forgotand)
yes, done.
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
PAL->PALs
Done.
-- commits, line 8 at r1:
Fixed typo, direcly -> directly
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel)
|
Jenkins, test this pleae |
|
Jenkins, test this please |
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions, not enough approvals from maintainers (1 more required)
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions
This function was introduced to copy topology information from `g_pal_sec` struct to `g_pal_public_state` for Linux-SGX PAL. Given that `pal_sec` struct was removed, we can remove this function and unify the behavior between Linux and Linux-SGX PALs to directly copy topology information to `g_pal_public_state`. Signed-off-by: Vijay Dhanraj <vijay.dhanraj@intel.com>
Signed-off-by: Vijay Dhanraj <vijay.dhanraj@intel.com>
vijaydhanraj
dismissed stale reviews from boryspoplawski, mkow, and dimakuv
via
79efb2f
vijaydhanraj
force-pushed
the
vdhanraj/refactor_sysfs_part3
branch
from
e820bb0 to
79efb2f
Compare
|
Jenkins, retest this please |
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL)
There was a problem hiding this comment.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
Description of the changes
This PR cleans up a few of the TODOs as part of refactoring sysfs.
How to test this PR?
Please run
sysfs_commonandproc_commonregression tests.This change is