Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add venv for Ubuntu 24.04 #214

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

adarshan-intel
Copy link
Contributor

@adarshan-intel adarshan-intel commented Aug 30, 2024

Description of the changes


This change is Reviewable

@adarshan-intel adarshan-intel changed the title Added venv for Ubuntu 24.04 [Doc] Added venv for Ubuntu 24.04 Aug 30, 2024
@adarshan-intel adarshan-intel force-pushed the adarsh/venv_addition branch 2 times, most recently from f59dc0f to 2836f83 Compare August 30, 2024 06:20
Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @adarshan-intel)


-- commits line 2 at r1:

[Docs] Add venv workaround for Ubuntu 24.04

Ubuntu 24.04 has a bug that prevents running GSC out-of-the-box, see
https://bugs.launchpad.net/ubuntu/+source/python-docker/+bug/2065348

Until this bug is fixed, users must prepare venv for GSC. Describe this.

Documentation/index.rst line 57 at r1 (raw file):

   pip3 install docker jinja2 tomli tomli-w pyyaml

On Ubuntu 24.04 (and any recent distro compliant with PEP 668) use Python virtual

This should be slightly different:

Python venv workaround for Ubuntu 24.04
---------------------------------------

Unfortunately, Ubuntu 24.04 (noble) has a `bug that prevents out-of-the-box
execution of
GSC<https://bugs.launchpad.net/ubuntu/+source/python-docker/+bug/2065348>`__.

Until this bug is fixed, GSC must be run on Ubuntu 24.04 via Python virtual
environment (venv). Please perform the following steps to install and activate
venv for GSC:

.. code-block:: sh

   sudo apt-get install python3-venv
   python3 -m venv my_venv && source my_venv/bin/activate
   pip3 install 'docker>=6.1.0' jinja2 tomli tomli-w pyyaml

Now you can execute GSC commands (`gsc build`, `gsc sign`, etc.) as usual,
within the virtual environment confines.

Copy link
Contributor Author

@adarshan-intel adarshan-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ), "fixup! " found in commit messages' one-liners (waiting on @dimakuv)


-- commits line 2 at r1:

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
[Docs] Add venv workaround for Ubuntu 24.04

Ubuntu 24.04 has a bug that prevents running GSC out-of-the-box, see
https://bugs.launchpad.net/ubuntu/+source/python-docker/+bug/2065348

Until this bug is fixed, users must prepare venv for GSC. Describe this.

Done.


Documentation/index.rst line 57 at r1 (raw file):

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

This should be slightly different:

Python venv workaround for Ubuntu 24.04
---------------------------------------

Unfortunately, Ubuntu 24.04 (noble) has a `bug that prevents out-of-the-box
execution of
GSC<https://bugs.launchpad.net/ubuntu/+source/python-docker/+bug/2065348>`__.

Until this bug is fixed, GSC must be run on Ubuntu 24.04 via Python virtual
environment (venv). Please perform the following steps to install and activate
venv for GSC:

.. code-block:: sh

   sudo apt-get install python3-venv
   python3 -m venv my_venv && source my_venv/bin/activate
   pip3 install 'docker>=6.1.0' jinja2 tomli tomli-w pyyaml

Now you can execute GSC commands (`gsc build`, `gsc sign`, etc.) as usual,
within the virtual environment confines.

Done.

Copy link
Contributor

@kailun-qin kailun-qin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ), "fixup! " found in commit messages' one-liners (waiting on @adarshan-intel and @dimakuv)


Documentation/index.rst line 62 at r2 (raw file):

Unfortunately, Ubuntu 24.04 (noble) has a `bug that prevents out-of-the-box
execution of
GSC<https://bugs.launchpad.net/ubuntu/+source/python-docker/+bug/2065348>`__.

I think a space is needed here -> GSC <

Code quote:

GSC<

Copy link
Contributor Author

@adarshan-intel adarshan-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ), "fixup! " found in commit messages' one-liners (waiting on @dimakuv and @kailun-qin)


Documentation/index.rst line 62 at r2 (raw file):

Previously, kailun-qin (Kailun Qin) wrote…

I think a space is needed here -> GSC <

Done.

Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ), "fixup! " found in commit messages' one-liners (waiting on @kailun-qin)


Documentation/index.rst line 62 at r2 (raw file):

Previously, adarshan-intel (Adarsh Anand) wrote…

Done.

No, the space is not needed, as this is the hyperlink syntax of RestructuredText. Please revert this change (or explain to me why this is necessary).

Copy link
Contributor Author

@adarshan-intel adarshan-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ), "fixup! " found in commit messages' one-liners (waiting on @dimakuv and @kailun-qin)


Documentation/index.rst line 62 at r2 (raw file):

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

No, the space is not needed, as this is the hyperlink syntax of RestructuredText. Please revert this change (or explain to me why this is necessary).

Done.

Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel), "fixup! " found in commit messages' one-liners (waiting on @kailun-qin)

Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ), "fixup! " found in commit messages' one-liners (waiting on @kailun-qin)


Documentation/index.rst line 62 at r2 (raw file):

Previously, adarshan-intel (Adarsh Anand) wrote…

Done.

I was wrong, sorry: https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#hyperlinks

Indeed, there needs to be a space after GSC... Sorry, please do it again, as Kailun requested.

Copy link
Contributor Author

@adarshan-intel adarshan-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ), "fixup! " found in commit messages' one-liners (waiting on @kailun-qin)


Documentation/index.rst line 62 at r2 (raw file):

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

I was wrong, sorry: https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#hyperlinks

Indeed, there needs to be a space after GSC... Sorry, please do it again, as Kailun requested.

Done.

Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel), "fixup! " found in commit messages' one-liners (waiting on @kailun-qin)

Copy link
Contributor

@kailun-qin kailun-qin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel), "fixup! " found in commit messages' one-liners

@adarshan-intel
Copy link
Contributor Author

@woju Please review this PR.

Copy link
Member

@woju woju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, "fixup! " found in commit messages' one-liners

Ubuntu 24.04 has a bug that prevents running GSC out-of-the-box, see
https://bugs.launchpad.net/ubuntu/+source/python-docker/+bug/2065348

Until this bug is fixed, users must prepare venv for GSC.

Signed-off-by: Adarsh Anand <adarsh.anand@intel.com>
Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, all discussions resolved, "fixup! " found in commit messages' one-liners

Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@woju woju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dimakuv dimakuv merged commit 3168b08 into gramineproject:master Sep 4, 2024
2 checks passed
@mkow mkow changed the title [Doc] Added venv for Ubuntu 24.04 [Doc] Add venv for Ubuntu 24.04 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants